From: ttn@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: PATCH: ewoc.el to permit node representation abutment
Date: Fri, 05 May 2006 17:43:18 -0400 [thread overview]
Message-ID: <E1Fc850-000129-4i@mail.agora-net.com> (raw)
In-Reply-To: <8764kkty67.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Fri, 05 May 2006 09:20:08 -0400)
From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Fri, 05 May 2006 09:20:08 -0400
Cool. I assume you tested it with the most important case: when the
pretty-printer returns the empty string (so you can temporarily hide
elements, which is the main reason why I wanted this feature
implemented).
actually, i didn't test that case (having in mind the munging of text
properties and `buffer-invisibility-spec' to implement hiding, instead).
i just started pcvs on a smallish project and typed `g' a few times.
anyway, looks like it will be handled in the process of solving...
The problem case is when we have at the same spot many empty
elements, and the one we refresh is one of the middle ones, so the
preceding ones shouldn't move but the subsequent ones should. It
seems your code doesn't pay attention to this detail and will either
move the preceding ones as well or fail to move the subsequent ones.
thanks for illustrating a concrete failure scenario. i had vague doubts
but now they are firmer. looks like slightly more hair is called for.
[eta reduction]
it would merit "bugfix" if the header and footer were ever refreshed,
but i see that `ewoc-refresh' avoids them -- ugh. (there seem to be
many design enhancement opportunities in ewoc.el...)
thi
next prev parent reply other threads:[~2006-05-05 21:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-05 12:03 PATCH: ewoc.el to permit node representation abutment Thien-Thi Nguyen
2006-05-05 13:20 ` Stefan Monnier
2006-05-05 21:43 ` ttn [this message]
2006-05-08 8:48 ` Thien-Thi Nguyen
2006-05-08 15:04 ` Stefan Monnier
2006-05-13 5:08 ` Thien-Thi Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Fc850-000129-4i@mail.agora-net.com \
--to=ttn@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).