From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.pretest.bugs,gmane.emacs.devel Subject: Re: tool-bar-setup overwrites local tool-bar-map Date: Sat, 29 Apr 2006 23:04:32 -0400 Message-ID: References: <31860.1145577819@olgas.newt.com> <423.1145580259@olgas.newt.com> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1146366471 4671 80.91.229.2 (30 Apr 2006 03:07:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 30 Apr 2006 03:07:51 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-pretest-bug-bounces+gebp-emacs-pretest-bug=gmane.org@gnu.org Sun Apr 30 05:07:50 2006 Return-path: Envelope-to: gebp-emacs-pretest-bug@gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fa2Hg-0001Mw-9x for gebp-emacs-pretest-bug@gmane.org; Sun, 30 Apr 2006 05:07:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fa2Hf-0008Pw-R5 for gebp-emacs-pretest-bug@gmane.org; Sat, 29 Apr 2006 23:07:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fa2Ec-0006q0-OU for emacs-pretest-bug@gnu.org; Sat, 29 Apr 2006 23:04:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fa2Ec-0006pk-7j for emacs-pretest-bug@gnu.org; Sat, 29 Apr 2006 23:04:34 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fa2Eb-0006pe-Ub; Sat, 29 Apr 2006 23:04:34 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fa2I6-0005Jz-KI; Sat, 29 Apr 2006 23:08:10 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1Fa2Ea-0003pr-TA; Sat, 29 Apr 2006 23:04:32 -0400 Original-To: Bill Wohler In-reply-to: <423.1145580259@olgas.newt.com> (message from Bill Wohler on Thu, 20 Apr 2006 17:44:19 -0700) X-BeenThere: emacs-pretest-bug@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for CVS Emacs." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-pretest-bug-bounces+gebp-emacs-pretest-bug=gmane.org@gnu.org Errors-To: emacs-pretest-bug-bounces+gebp-emacs-pretest-bug=gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.pretest.bugs:11868 gmane.emacs.devel:53637 Archived-At: > To see what should have happened: > > emacs22 -Q > M-x tool-bar-mode > > Note how Preferences and Help icons are present. > > M-x info > > Note how Preferences and Help icons are absent. In what sense is that "what should have happened"? I do not follow. Shouldn't the Preferences and Help icons always be present? No, I may not ;-). It breaks the idiom from the tool-bar-add-item documentation, namely: (defvar foo-tool-bar-map (let ((tool-bar-map (make-sparse-keymap))) (tool-bar-add-item ...) ... tool-bar-map)) It also did some mean and nasty things to the MH-E toolbar. The following patch (to tool-bar-setup) seems to be working a little better. What are you asking us to do?