From: Richard Stallman <rms@gnu.org>
Cc: rudalics@gmx.at, emacs-devel@gnu.org
Subject: Re: Bugs in remove-list-of-text-properties and a patch [WAS: before-change-functions called twice at yank]
Date: Mon, 17 Apr 2006 21:42:16 -0400 [thread overview]
Message-ID: <E1FVfEO-0003qS-2M@fencepost.gnu.org> (raw)
In-Reply-To: <44435682.4050409@soem.dk> (message from Lars Hansen on Mon, 17 Apr 2006 10:49:06 +0200)
The general idea is:
Fremove_list_of_text_properties has a for (;;) loop that loops over the
parts of the interval. It updates the flag `modified' recording if
changes have been done. To make things work right, we must call
modify_region before calling remove_properties iff modified == 0, and we
must call signal_after_change before returning iff modified != 0.
Would you please add that explanation as a comment?
And maybe this one too:
The before-change-functions are run by modify_region called immediately
before the changes are done by remove_properties.
next prev parent reply other threads:[~2006-04-18 1:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 22:37 before-change-functions called twice at yank Lars Hansen
2006-04-11 6:58 ` martin rudalics
2006-04-11 7:23 ` Lars Hansen
2006-04-15 18:57 ` Bugs in remove-list-of-text-properties and a patch [WAS: before-change-functions called twice at yank] Lars Hansen
2006-04-17 0:56 ` Richard Stallman
2006-04-17 8:51 ` Lars Hansen
[not found] ` <44435682.4050409@soem.dk>
2006-04-18 1:42 ` Richard Stallman [this message]
2006-04-20 11:46 ` Lars Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1FVfEO-0003qS-2M@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).