* sort-first arg to map-keymap
@ 2006-03-27 6:44 Stefan Monnier
2006-03-28 19:33 ` Richard Stallman
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2006-03-27 6:44 UTC (permalink / raw)
Does anyone know why we have the `sort-first' arg to map-keymap?
It doesn't seem to be used anywhere and its implementation is rather odd
(its handling is delegated from C to Lisp's map-keymap-internal which them
calls back C's map-keymap function, with an apparent-only circular
dependency).
As best as I can tell, it comes from emacs-lisp/lucid.el which is a brittle
package which tries to provide very coarse XEmacs compatibility; but
XEmacs's `map-keymap' function doesn't behave like ours anyway (it doesn't
apply the function to the keymap's parents, for one thing), and lucid.el has
never been very highly used, so it seems better to keep its brittle code in
lucid.el than to move it to subr.el.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: sort-first arg to map-keymap
2006-03-27 6:44 sort-first arg to map-keymap Stefan Monnier
@ 2006-03-28 19:33 ` Richard Stallman
2006-03-28 19:46 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Richard Stallman @ 2006-03-28 19:33 UTC (permalink / raw)
Cc: emacs-devel
As best as I can tell, it comes from emacs-lisp/lucid.el which is a brittle
package which tries to provide very coarse XEmacs compatibility; but
XEmacs's `map-keymap' function doesn't behave like ours anyway (it doesn't
apply the function to the keymap's parents, for one thing), and lucid.el has
never been very highly used, so it seems better to keep its brittle code in
lucid.el than to move it to subr.el.
You may be right, but why change this now?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: sort-first arg to map-keymap
2006-03-28 19:33 ` Richard Stallman
@ 2006-03-28 19:46 ` Stefan Monnier
2006-03-29 23:01 ` Richard Stallman
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2006-03-28 19:46 UTC (permalink / raw)
Cc: emacs-devel
> As best as I can tell, it comes from emacs-lisp/lucid.el which is
> a brittle package which tries to provide very coarse XEmacs
> compatibility; but XEmacs's `map-keymap' function doesn't behave like
> ours anyway (it doesn't apply the function to the keymap's parents,
> for one thing), and lucid.el has never been very highly used, so it
> seems better to keep its brittle code in lucid.el than to move it to
> subr.el.
> You may be right, but why change this now?
Just because the code (which is new in Emacs-22's subr.el) is (as mentioned)
brittle, so it may bite us down the road.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: sort-first arg to map-keymap
2006-03-28 19:46 ` Stefan Monnier
@ 2006-03-29 23:01 ` Richard Stallman
0 siblings, 0 replies; 4+ messages in thread
From: Richard Stallman @ 2006-03-29 23:01 UTC (permalink / raw)
Cc: emacs-devel
> You may be right, but why change this now?
Just because the code (which is new in Emacs-22's subr.el) is (as mentioned)
brittle, so it may bite us down the road.
I agree, but let's change it after the release.
It is not urgent to make it less brittle.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-03-29 23:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-27 6:44 sort-first arg to map-keymap Stefan Monnier
2006-03-28 19:33 ` Richard Stallman
2006-03-28 19:46 ` Stefan Monnier
2006-03-29 23:01 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).