From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: locate-with-filter Date: Sat, 18 Mar 2006 03:44:03 -0500 Message-ID: References: <200603160048.k2G0msu23696@raven.dms.auburn.edu> <200603170221.k2H2L1H14401@raven.dms.auburn.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1142671548 18500 80.91.229.2 (18 Mar 2006 08:45:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 18 Mar 2006 08:45:48 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 18 09:45:47 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FKX4A-0002cf-SN for ged-emacs-devel@m.gmane.org; Sat, 18 Mar 2006 09:45:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FKX4A-0004fj-11 for ged-emacs-devel@m.gmane.org; Sat, 18 Mar 2006 03:45:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FKX2b-0003vC-SG for emacs-devel@gnu.org; Sat, 18 Mar 2006 03:44:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FKX2a-0003ta-ER for emacs-devel@gnu.org; Sat, 18 Mar 2006 03:44:05 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FKX2a-0003tD-3Y for emacs-devel@gnu.org; Sat, 18 Mar 2006 03:44:04 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FKX7e-0005dL-04 for emacs-devel@gnu.org; Sat, 18 Mar 2006 03:49:18 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1FKX2Z-0003qA-3h; Sat, 18 Mar 2006 03:44:03 -0500 Original-To: Luc Teirlinck In-reply-to: <200603170221.k2H2L1H14401@raven.dms.auburn.edu> (message from Luc Teirlinck on Thu, 16 Mar 2006 20:21:01 -0600 (CST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51794 Archived-At: I think we can effectively eliminate help-follow. It is not used for following any of the links that are explicitly presented in the doc string. So I propose this change: *** help-mode.el 07 Feb 2006 18:16:11 -0500 1.43 --- help-mode.el 17 Mar 2006 16:30:23 -0500 *************** Commands: *** 233,242 **** "Label to use by `help-make-xrefs' for the go-back reference.") (defconst help-xref-symbol-regexp ! (purecopy (concat "\\(\\<\\(\\(variable\\|option\\)\\|" ! "\\(function\\|command\\)\\|" ! "\\(face\\)\\|" ! "\\(symbol\\)\\|" "\\(source \\(?:code \\)?\\(?:of\\|for\\)\\)\\)" "[ \t\n]+\\)?" ;; Note starting with word-syntax character: --- 233,242 ---- "Label to use by `help-make-xrefs' for the go-back reference.") (defconst help-xref-symbol-regexp ! (purecopy (concat "\\(\\<\\(\\(variable\\|option\\)\\|" ; Link to var ! "\\(function\\|command\\)\\|" ; Link to function ! "\\(face\\)\\|" ; Link to face ! "\\(symbol\\|program\\)\\|" ; Don't link "\\(source \\(?:code \\)?\\(?:of\\|for\\)\\)\\)" "[ \t\n]+\\)?" ;; Note starting with word-syntax character: *************** help buffer." *** 584,598 **** ;; Navigation/hyperlinking with xrefs - (defun help-follow-mouse (click) - "Follow the cross-reference that you CLICK on." - (interactive "e") - (let* ((start (event-start click)) - (window (car start)) - (pos (car (cdr start)))) - (with-current-buffer (window-buffer window) - (help-follow pos)))) - (defun help-xref-go-back (buffer) "From BUFFER, go back to previous help buffer text using `help-xref-stack'." (let (item position method args) --- 584,589 ---- *************** a proper [back] button." *** 627,637 **** --- 618,637 ---- (let ((help-xref-following t)) (apply function args))) + ;; The doc string is meant to explain what buttons do. + (defun help-follow-mouse (click) + "Follow the cross-reference that you CLICK on." + (interactive "e") + (error "No cross-reference here")) + + ;; The doc string is meant to explain what buttons do. (defun help-follow (&optional pos) "Follow cross-reference at POS, defaulting to point. For the cross-reference format, see `help-make-xrefs'." (interactive "d") + (error "No cross-reference here")) + (unless pos (setq pos (point))) (unless (push-button pos)