unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: locate-with-filter
Date: Sat, 18 Mar 2006 03:44:03 -0500	[thread overview]
Message-ID: <E1FKX2Z-0003qA-3h@fencepost.gnu.org> (raw)
In-Reply-To: <200603170221.k2H2L1H14401@raven.dms.auburn.edu> (message from Luc Teirlinck on Thu, 16 Mar 2006 20:21:01 -0600 (CST))

I think we can effectively eliminate help-follow.  It is not used for
following any of the links that are explicitly presented in the doc
string.

So I propose this change:


*** help-mode.el	07 Feb 2006 18:16:11 -0500	1.43
--- help-mode.el	17 Mar 2006 16:30:23 -0500	
*************** Commands:
*** 233,242 ****
    "Label to use by `help-make-xrefs' for the go-back reference.")
  
  (defconst help-xref-symbol-regexp
!   (purecopy (concat "\\(\\<\\(\\(variable\\|option\\)\\|"
! 		    "\\(function\\|command\\)\\|"
! 		    "\\(face\\)\\|"
! 		    "\\(symbol\\)\\|"
  		    "\\(source \\(?:code \\)?\\(?:of\\|for\\)\\)\\)"
  		    "[ \t\n]+\\)?"
  		    ;; Note starting with word-syntax character:
--- 233,242 ----
    "Label to use by `help-make-xrefs' for the go-back reference.")
  
  (defconst help-xref-symbol-regexp
!   (purecopy (concat "\\(\\<\\(\\(variable\\|option\\)\\|"  ; Link to var
! 		    "\\(function\\|command\\)\\|"          ; Link to function
! 		    "\\(face\\)\\|"			   ; Link to face
! 		    "\\(symbol\\|program\\)\\|"		   ; Don't link
  		    "\\(source \\(?:code \\)?\\(?:of\\|for\\)\\)\\)"
  		    "[ \t\n]+\\)?"
  		    ;; Note starting with word-syntax character:
*************** help buffer."
*** 584,598 ****
  \f
  ;; Navigation/hyperlinking with xrefs
  
- (defun help-follow-mouse (click)
-   "Follow the cross-reference that you CLICK on."
-   (interactive "e")
-   (let* ((start (event-start click))
- 	 (window (car start))
- 	 (pos (car (cdr start))))
-     (with-current-buffer (window-buffer window)
-       (help-follow pos))))
- 
  (defun help-xref-go-back (buffer)
    "From BUFFER, go back to previous help buffer text using `help-xref-stack'."
    (let (item position method args)
--- 584,589 ----
*************** a proper [back] button."
*** 627,637 ****
--- 618,637 ----
    (let ((help-xref-following t))
      (apply function args)))
  
+ ;; The doc string is meant to explain what buttons do.
+ (defun help-follow-mouse (click)
+   "Follow the cross-reference that you CLICK on."
+   (interactive "e")
+   (error "No cross-reference here"))
+ 
+ ;; The doc string is meant to explain what buttons do.
  (defun help-follow (&optional pos)
    "Follow cross-reference at POS, defaulting to point.
  
  For the cross-reference format, see `help-make-xrefs'."
    (interactive "d")
+   (error "No cross-reference here"))
+ 
    (unless pos
      (setq pos (point)))
    (unless (push-button pos)

  reply	other threads:[~2006-03-18  8:44 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-11 23:46 locate-with-filter Richard Stallman
2006-03-12 23:59 ` locate-with-filter Luc Teirlinck
2006-03-13  0:18   ` locate-with-filter Luc Teirlinck
2006-03-13  4:39     ` locate-with-filter Eli Zaretskii
2006-03-13 11:30       ` locate-with-filter Peter Breton
2006-03-13 12:55   ` locate-with-filter Richard Stallman
2006-03-14  2:55     ` locate-with-filter Luc Teirlinck
2006-03-14  4:41       ` locate-with-filter Eli Zaretskii
2006-03-14  5:39         ` locate-with-filter Luc Teirlinck
2006-03-14 16:09       ` locate-with-filter Richard Stallman
2006-03-15  5:41         ` locate-with-filter Luc Teirlinck
2006-03-15 13:33           ` locate-with-filter Luc Teirlinck
2006-03-15 13:39             ` locate-with-filter Luc Teirlinck
2006-03-15 20:23           ` locate-with-filter Richard Stallman
2006-03-15 22:47             ` locate-with-filter Luc Teirlinck
2006-03-16 20:18               ` locate-with-filter Richard Stallman
2006-03-17  1:38                 ` locate-with-filter Luc Teirlinck
2006-03-17  2:21                 ` locate-with-filter Luc Teirlinck
2006-03-18  8:44                   ` Richard Stallman [this message]
2006-03-18  8:59                     ` locate-with-filter Nick Roberts
2006-03-18 17:16                       ` locate-with-filter Luc Teirlinck
2006-03-19  4:15                         ` locate-with-filter Nick Roberts
2006-03-19  3:50                           ` locate-with-filter Luc Teirlinck
2006-03-19  4:55                           ` locate-with-filter Luc Teirlinck
2006-03-19  5:09                             ` locate-with-filter Luc Teirlinck
2006-03-19  5:22                               ` locate-with-filter Luc Teirlinck
2006-03-19 21:51                             ` locate-with-filter Richard Stallman
2006-03-20  5:12                               ` locate-with-filter Luc Teirlinck
2006-03-21  1:02                                 ` locate-with-filter Richard Stallman
2006-03-21  1:13                                   ` locate-with-filter Luc Teirlinck
2006-03-29  4:09                                   ` locate-with-filter Luc Teirlinck
2006-03-29 23:02                                     ` locate-with-filter Richard Stallman
2006-03-30  0:29                                       ` locate-with-filter Luc Teirlinck
2006-03-31  3:10                                         ` locate-with-filter Richard Stallman
2006-04-01  1:34                                           ` locate-with-filter Luc Teirlinck
2006-04-01  1:52                                           ` locate-with-filter Luc Teirlinck
2006-03-19  9:09                       ` locate-with-filter Richard Stallman
2006-03-19 20:15                         ` locate-with-filter Nick Roberts
2006-03-19 20:19                           ` locate-with-filter Luc Teirlinck
2006-03-19 22:05                             ` locate-with-filter Nick Roberts
2006-03-20 15:05                           ` locate-with-filter Richard Stallman
2006-03-19  1:28                     ` locate-with-filter Luc Teirlinck
2006-03-19  2:29                       ` locate-with-filter Luc Teirlinck
2006-03-20  6:18                 ` locate-with-filter Stefan Monnier
2006-03-14 16:09       ` locate-with-filter Richard Stallman
2006-03-15  5:37         ` locate-with-filter Luc Teirlinck
2006-03-15  5:48         ` locate-with-filter Luc Teirlinck
2006-03-15 20:23           ` locate-with-filter Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1FKX2Z-0003qA-3h@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).