From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: "Richard M. Stallman" <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: crash in the cvs head build of Feb 13 08:40
Date: Sun, 19 Feb 2006 12:45:43 -0500
Message-ID: <E1FAscx-0006Nc-LI@fencepost.gnu.org>
References: <alirrgd95z.fsf@quant8.janestcapital.quant>
Reply-To: rms@gnu.org
NNTP-Posting-Host: main.gmane.org
Content-Type: text/plain; charset=ISO-8859-15
X-Trace: sea.gmane.org 1140388881 8347 80.91.229.2 (19 Feb 2006 22:41:21 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sun, 19 Feb 2006 22:41:21 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 19 23:41:19 2006
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1FAxEz-0005TQ-G0
	for ged-emacs-devel@m.gmane.org; Sun, 19 Feb 2006 23:41:18 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1FAxEx-0007pD-Up
	for ged-emacs-devel@m.gmane.org; Sun, 19 Feb 2006 17:41:15 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FAtCI-0001Mj-CW
	for emacs-devel@gnu.org; Sun, 19 Feb 2006 13:22:15 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FAsyQ-0006nk-1P
	for emacs-devel@gnu.org; Sun, 19 Feb 2006 13:08:54 -0500
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FAscy-0003Fq-JI
	for emacs-devel@gnu.org; Sun, 19 Feb 2006 12:45:46 -0500
Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1FAsip-000770-H3
	for emacs-devel@gnu.org; Sun, 19 Feb 2006 12:51:47 -0500
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34)
	id 1FAscx-0006Nc-LI; Sun, 19 Feb 2006 12:45:43 -0500
Original-To: sds@gnu.org
In-reply-to: <alirrgd95z.fsf@quant8.janestcapital.quant> (message from Sam
	Steingold on Wed, 15 Feb 2006 08:49:12 -0500)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:50762
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/50762>

In this case I think it is better to be less defensive
and stick more clearly to the rules from which the code was written.
Does this patch fix the bug?

*** xmenu.c	07 Feb 2006 18:13:41 -0500	1.299
--- xmenu.c	19 Feb 2006 11:46:11 -0500	
***************
*** 1807,1814 ****
  	      wv->enabled = 1;
  	      wv->button_type = BUTTON_TYPE_NONE;
  	      wv->help = Qnil;
  	    }
! 	  save_wv = wv;
  	  prev_wv = 0;
  	  i += MENU_ITEMS_PANE_LENGTH;
  	}
--- 1807,1817 ----
  	      wv->enabled = 1;
  	      wv->button_type = BUTTON_TYPE_NONE;
  	      wv->help = Qnil;
+ 	      save_wv = wv;
  	    }
! 	  else
! 	    save_wv = first_wv;
! 
  	  prev_wv = 0;
  	  i += MENU_ITEMS_PANE_LENGTH;
  	}