From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ralf Angeli Newsgroups: gmane.emacs.cc-mode.general,gmane.emacs.devel Subject: Re: [sigra@home.se: C++-mode: Syntax highlighting: wrong color for function identifier depending on the kind of whitespace that follows] Date: Wed, 15 Feb 2006 22:42:02 +0100 Organization: nil Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1140043421 1057 80.91.229.2 (15 Feb 2006 22:43:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 15 Feb 2006 22:43:41 +0000 (UTC) Cc: Stefan Monnier , bug-cc-mode@gnu.org, rms@gnu.org, emacs-devel@gnu.org Original-X-From: cc-mode-help-admin@lists.sourceforge.net Wed Feb 15 23:43:33 2006 Return-path: Envelope-to: sf-cc-mode-help@m.gmane.org Original-Received: from lists-outbound.sourceforge.net ([66.35.250.225]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F9VMd-0005us-FA for sf-cc-mode-help@m.gmane.org; Wed, 15 Feb 2006 23:43:11 +0100 Original-Received: from sc8-sf-list1-b.sourceforge.net (sc8-sf-list1-b.sourceforge.net [10.3.1.7]) by sc8-sf-spam2.sourceforge.net (Postfix) with ESMTP id AF77A12E00; Wed, 15 Feb 2006 14:43:10 -0800 (PST) Original-Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1F9VMO-0007jF-0U for cc-mode-help@lists.sourceforge.net; Wed, 15 Feb 2006 14:42:56 -0800 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by mail.sourceforge.net with esmtps (TLSv1:RC4-SHA:128) (Exim 4.44) id 1F9VMM-0004jq-H1 for cc-mode-help@lists.sourceforge.net; Wed, 15 Feb 2006 14:42:56 -0800 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.34) id 1F9VMJ-0001bQ-D9 for bug-cc-mode@gnu.org; Wed, 15 Feb 2006 17:42:51 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.52) id 1F9VRG-0005Bh-20 for bug-cc-mode@gnu.org; Wed, 15 Feb 2006 17:48:01 -0500 Original-Received: from [134.96.7.25] (helo=triton.rz.uni-saarland.de) by monty-python.gnu.org with esmtp (Exim 4.52) id 1F9VRC-0005Av-7y; Wed, 15 Feb 2006 17:47:54 -0500 Original-Received: from iwi-gate.iwi.uni-sb.de (iwi-gate.iwi.uni-saarland.de [134.96.72.13]) by triton.rz.uni-saarland.de (8.12.10/8.12.10) with ESMTP id k1FMgDbO10513659; Wed, 15 Feb 2006 23:42:13 +0100 (CET) Original-Received: from [134.96.72.191] (helo=iwi191.iwi.uni-sb.de) by iwi-gate.iwi.uni-sb.de with esmtp (Exim 4.53 (FreeBSD)) id 1F9VLW-000ODY-M4; Wed, 15 Feb 2006 23:42:02 +0100 Original-Received: from angeli by iwi191.iwi.uni-sb.de with local (Exim 4.60) (envelope-from ) id 1F9UPS-0006Us-Pe; Wed, 15 Feb 2006 22:42:02 +0100 Original-To: Alan Mackenzie In-Reply-To: (Alan Mackenzie's message of "Wed, 15 Feb 2006 19:07:31 +0000 (GMT)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-IWi-MailScanner-Information: Please contact the ISP for more information X-IWi-MailScanner: Found to be clean X-IWi-MailScanner-SpamCheck: not spam, SpamAssassin (score=0, required 5, autolearn=disabled) X-MailScanner-From: angeli@iwi.uni-sb.de X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.5.1 (triton.rz.uni-saarland.de [134.96.7.25]); Wed, 15 Feb 2006 23:42:13 +0100 (CET) X-AntiVirus: checked by AntiVir Milter (version: 1.1.1-9; AVE: 6.33.0.31; VDF: 6.33.0.240; host: AntiVir2) X-Spam-Score: 1.0 (+) X-Spam-Report: Spam Filtering performed by sourceforge.net. See http://spamassassin.org/tag/ for more details. Report problems to http://sf.net/tracker/?func=add&group_id=1&atid=200001 1.0 FORGED_RCVD_HELO Received: contains a forged HELO Original-Sender: cc-mode-help-admin@lists.sourceforge.net Errors-To: cc-mode-help-admin@lists.sourceforge.net X-BeenThere: cc-mode-help@lists.sourceforge.net X-Mailman-Version: 2.0.9-sf.net Precedence: bulk List-Unsubscribe: , List-Id: Bug reports, feature requests, and general talk about CC Mode. List-Post: List-Help: List-Subscribe: , List-Archive: X-Original-Date: Wed, 15 Feb 2006 22:42:02 +0100 Xref: news.gmane.org gmane.emacs.cc-mode.general:3014 gmane.emacs.devel:50586 Archived-At: * Alan Mackenzie (2006-02-15) writes: > On Sun, 12 Feb 2006, Stefan Monnier wrote: > >>.... Based on the name, I suppose it's some kind of hook in >>font-lock-after-change-function, in which case I'd be tempted to suggest >>to move it to font-lock-fontify-region instead, to reduce the >>performance impact and make it easier to deal with lazy-lock&jit-lock >>since these tend to use their own after-change-function. > > I strongly oppose such a change. With that change: > > (i) font-lock-fontify-region would no longer be fontifying the region > specified by its paramters, but a different (possibly larger) one. > (ii) the hook function (which recalculates BEG and END) might well refer > to variables set by a before-change-functions hook. (This is done in AWK > mode, for example). f-l-f-region is regularly called when there is no > buffer change in progress. > > Both of these things would make debugging a hook function much more > difficult than it already is. Determining the region to fontify and > actually fontifying it are two logically distinct operations. They > shouldn't be intermingled with eachother. This is all well and good, but in contrast to the after-change hook, a hook in `font-lock-default-fontify-region' could not only adjust the region after a change but also during fontification by chunks as done by jit-lock. (That's an advantage I haven't noticed before.) Following your reasoning of separating the determination of the region to be fontified from the fontification itself would require that jit-lock determines the chunks to be fontified more intelligently. -- Ralf ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642