From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: Visual cleanup for customize buffers Date: Sun, 05 Feb 2006 21:07:15 -0500 Message-ID: References: <200601142305.k0EN5Nl22098@raven.dms.auburn.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1139191923 14911 80.91.229.2 (6 Feb 2006 02:12:03 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 6 Feb 2006 02:12:03 +0000 (UTC) Cc: teirllm@dms.auburn.edu, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 06 03:12:01 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F5vrE-0004NI-Sf for ged-emacs-devel@m.gmane.org; Mon, 06 Feb 2006 03:12:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F5vuW-0003KV-6I for ged-emacs-devel@m.gmane.org; Sun, 05 Feb 2006 21:15:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F5vrK-0001DT-RH for emacs-devel@gnu.org; Sun, 05 Feb 2006 21:12:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F5vrK-0001DC-9V for emacs-devel@gnu.org; Sun, 05 Feb 2006 21:12:06 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F5vrK-0001D7-3J for emacs-devel@gnu.org; Sun, 05 Feb 2006 21:12:06 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1F5vqn-0008In-IM for emacs-devel@gnu.org; Sun, 05 Feb 2006 21:11:33 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1F5vmd-0002ux-Ip; Sun, 05 Feb 2006 21:07:15 -0500 Original-To: storm@cua.dk (Kim F. Storm) In-reply-to: (storm@cua.dk) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50070 Archived-At: --- 2551,2558 ---- ;; this anyway. The doc string widget should be added like the others. ;; --dv (widget-put widget :buttons buttons) ! (unless (eq (preceding-char) ?\n) ! (insert "\n")) ;; Insert documentation. (widget-default-format-handler widget ?h) If this deletes the blank line after the STATE line, I am against it, for reasons I stated here before. (define-widget 'custom-face-edit 'checklist "Edit face attributes." ! :format "%t:\n %v" :tag "Attributes" :extra-offset 13 :button-args '(:help-echo "Control whether this attribute has any effect.") What is the user-visible effect of that? ((eq escape ?\]) ! (save-excursion ! (setq button-end (point)) ! (when value-choice-button ! (goto-char button-begin) ! (when (re-search-forward "[:\n]" button-end t) ! (setq button-end (1- (point)))) ! (goto-char button-end) ! (when (eq (preceding-char) ?\n) ! (backward-char 1)) ! (insert " ") ! (if (display-graphic-p) ! (insert-image ! (or widget-choice-menu-image ! (setq widget-choice-menu-image ! (create-image "\377\176\176\074\074\030\030\377" ! 'xbm t :width 8 :height 8 ! :foreground ! (if (facep 'custom-button) ! (face-foreground 'custom-button) ! "black") ! :background ! (if (facep 'custom-button) ! (face-background 'custom-button) ! "lightgrey") ! :ascent 'center))) ">") ! (insert (propertize "?>" ))) ! (setq button-end (point))) ! (insert (widget-get-indirect widget :button-suffix)))) ((eq escape ?\{) (setq sample-begin (point))) ((eq escape ?\}) What does that do? (It needs comments!) --- 3596,3602 ---- (define-widget 'choice 'menu-choice "A union of several sexp types." :tag "Choice" ! :format "%{%t%}: %[%V%]" :button-prefix 'widget-push-button-prefix :button-suffix 'widget-push-button-suffix :prompt-value 'widget-choice-prompt-value) What user-visible change does that make?