From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: menu-bar: disable items when no frame visible Date: Sat, 24 Dec 2005 21:51:22 -0500 Message-ID: References: <708F3D2D-A87C-4F80-BC27-171D82653F4D@gmail.com> <069BF3EB-C5E4-4042-91E9-0DFB37C58E99@gmail.com> <87u0d3cu9y.fsf@jurta.org> <87y82b7evb.fsf@jurta.org> <9F80EEEC-3EDF-47B5-9837-2091650A8C5D@gmail.com> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1135479163 24698 80.91.229.2 (25 Dec 2005 02:52:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 25 Dec 2005 02:52:43 +0000 (UTC) Cc: juri@jurta.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 25 03:52:40 2005 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EqLzv-0004dh-Pa for ged-emacs-devel@m.gmane.org; Sun, 25 Dec 2005 03:52:36 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EqM13-0004Q7-No for ged-emacs-devel@m.gmane.org; Sat, 24 Dec 2005 21:53:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EqM0F-00045r-D0 for emacs-devel@gnu.org; Sat, 24 Dec 2005 21:52:55 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EqM0E-00045b-ME for emacs-devel@gnu.org; Sat, 24 Dec 2005 21:52:55 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EqM0E-00045W-9F for emacs-devel@gnu.org; Sat, 24 Dec 2005 21:52:54 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EqLzn-00005D-Ro for emacs-devel@gnu.org; Sat, 24 Dec 2005 21:52:27 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1EqLyk-0007ap-BN; Sat, 24 Dec 2005 21:51:22 -0500 Original-To: David Reitter In-reply-to: <9F80EEEC-3EDF-47B5-9837-2091650A8C5D@gmail.com> (message from David Reitter on Sat, 24 Dec 2005 13:15:28 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:48341 Archived-At: But I would suggest improving find-file to catch the error in switch- to-buffer and show the buffer in another window in that case, at least when called interactively. Why do you find it so often useful to invoke Find File while you're in a minibuffer? > (define-key menu-bar-edit-menu [bookmark] > - '(menu-item "Bookmarks" menu-bar-bookmark-map > + `(menu-item "Bookmarks" ,menu-bar-bookmark-map > :help "Record positions and jump between them")) Thanks for pointing this out, maybe that's a bug in the patch. Let's leave this particular change out. Now I understand the context of this question. Amd I see that menu-bar-bookmark-map has a function definition the same as its value--that is what makes it work correctly to use the symbol instead of the map itself.