From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: GC garbles menu items (was: tooltip can be displayed outside the screen) Date: Sat, 17 Dec 2005 19:00:12 -0500 Message-ID: References: <4390611E.3040500@swipnet.se> <4391A9CE.6090706@swipnet.se> <87acffdnrg.fsf@jurta.org> <439D501F.8060609@swipnet.se> <87pso1bdrb.fsf@jurta.org> <43A08825.8070704@swipnet.se> <87k6e6myqw.fsf@jurta.org> <873bkte58s.fsf@jurta.org> <87ek4cngkz.fsf_-_@jurta.org> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1134864708 11174 80.91.229.2 (18 Dec 2005 00:11:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 18 Dec 2005 00:11:48 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 18 01:11:46 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Enm7f-0003XT-HB for ged-emacs-devel@m.gmane.org; Sun, 18 Dec 2005 01:09:55 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Enm8R-00008K-2v for ged-emacs-devel@m.gmane.org; Sat, 17 Dec 2005 19:10:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Enm0j-00068x-64 for emacs-devel@gnu.org; Sat, 17 Dec 2005 19:02:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Enm0g-00067h-HP for emacs-devel@gnu.org; Sat, 17 Dec 2005 19:02:43 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Enm0f-00067G-Da for emacs-devel@gnu.org; Sat, 17 Dec 2005 19:02:41 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Enm3L-0003X1-Hz for emacs-devel@gnu.org; Sat, 17 Dec 2005 19:05:27 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1EnlyG-0000wF-Fw; Sat, 17 Dec 2005 19:00:12 -0500 Original-To: Juri Linkov In-reply-to: <87ek4cngkz.fsf_-_@jurta.org> (message from Juri Linkov on Sat, 17 Dec 2005 12:48:48 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:47971 Archived-At: I can reproduce this bug only on non-toolkit builds. Aha, now I see. The non-toolkit definition of xmenu_show copies the addresses of string text directly into the non-toolkit menu data. When GC happens, it relocates the strings and garbles the text. Could you rewrite that code to copy the strings when making the menus, and free the copies at the end? I think that code was written before we made Emacs GC during idle time and before there were timers. Back then, it was probably impossible to GC while the menu was up.