From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: [drew.adams@oracle.com: RE: weird defadvice bug with byte-compilation] Date: Sun, 04 Dec 2005 21:36:26 -0500 Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1133750401 13200 80.91.229.2 (5 Dec 2005 02:40:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 5 Dec 2005 02:40:01 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 05 03:39:52 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Ej6FL-000243-Od for ged-emacs-devel@m.gmane.org; Mon, 05 Dec 2005 03:38:32 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ej6FS-0006cX-Mh for ged-emacs-devel@m.gmane.org; Sun, 04 Dec 2005 21:38:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ej6Dk-0005CP-Nr for emacs-devel@gnu.org; Sun, 04 Dec 2005 21:36:53 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ej6Dj-0005BN-BG for emacs-devel@gnu.org; Sun, 04 Dec 2005 21:36:51 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ej6Dj-0005BI-6x for emacs-devel@gnu.org; Sun, 04 Dec 2005 21:36:51 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Ej6E9-0002SR-GP for emacs-devel@gnu.org; Sun, 04 Dec 2005 21:37:17 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1Ej6DK-0001dl-VO; Sun, 04 Dec 2005 21:36:27 -0500 Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46984 Archived-At: Would someone please investigate this bug, and ack? It needs to be debugged for the release. ------- Start of forwarded message ------- From: "Drew Adams" To: "Emacs-Pretest-Bug" Date: Tue, 22 Nov 2005 09:32:25 -0800 In-Reply-To: X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE Subject: RE: weird defadvice bug with byte-compilation Sender: emacs-pretest-bug-bounces+rms=gnu.org@gnu.org X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on monty-python X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.63 Not sure if anyone is looking into this bug. I know it sounds as if it's quite particular (corner case), but I suspect that this may point to something improper in the byte-compiler code. And it does systematically produce a fatal error. - Drew - ---------- This is a weird one. I've pared it down to the bare bones, I think - if I comment out any part of this, the bug doesn't occur. This obviously comes from a larger context - when it is pared down, the code doesn't make much sense, of course. If the stuff is in the same file, or the order is different, no bug (error). It must be like this: two files, one of which is compiled and required by the other. And the requiring file must have "compile" in its defadvice. Two files: File 1: foo.el -------------- (defvar mymap nil "") (let ((map (make-sparse-keymap "II"))) (setq mymap (make-sparse-keymap)) (define-key menu-bar-search-menu [ise] '("" . ise)) (put 'ise 'menu-enable '(and my-mode)) (push (cons 'my-mode mymap) minor-mode-map-alist)) (defadvice next-history-element (after ffff activate) "" my-mode) (provide 'foo) File 2: bar.el -------------- (defconst special-display-regexps '("[ ]?[*][^*]+[*]")) (defvar drews-lisp-dir "C:\\drews-lisp-20" "") (setq load-path (append (list drews-lisp-dir) load-path)) (defadvice occur-mode-goto-occurrence (around jjjjjj activate compile) "" ad-do-it) (require 'foo) Instructions: ------------- 1. emacs -q 2. Byte-compile foo.el (it doesn't matter if it's compiled on Emacs 20 or 22). `C-x C-c'. 3. emacs -q (Emacs 22) 4. Visit bar.el - don't load it. 5. Select everything in bar.el except the (require 'foo), and do `eval-region'. 6. Put the cursor just after the (require 'foo) and do `C-x C-e'. (Don't select it and do eval-region - that doesn't produce the bug!) You will get this error backtrace: Debugger entered--Lisp error: (void-variable my-mode) (and my-mode) x-create-frame(((visibility) (height . 14) (width . 80) (unsplittable . t))) x-create-frame-with-faces(((height . 14) (width . 80) (unsplittable . t))) make-frame(((height . 14) (width . 80) (unsplittable . t))) special-display-popup-frame(#) display-buffer(#) display-warning(bytecomp "reference to free variable `my-mode'" :warning "*Compile-Log*") byte-compile-log-warning("reference to free variable `my-mode'" t :warning) byte-compile-warn("reference to free variable `%s'" my-mode) byte-compile-variable-ref(byte-varref my-mode) byte-compile-form(my-mode t) byte-compile-body(((setq ad-return-value (ad-Orig-next-history-element n)) my-mode ad-return-value) nil) byte-compile-let((let (ad-return-value) (setq ad-return-value (ad-Orig-next-history-element n)) my-mode ad-return-value)) byte-compile-form((let (ad-return-value) (setq ad-return-value (ad-Orig-next-history-element n)) my-mode ad-return-value) nil) byte-compile-top-level((progn (let (ad-return-value) (setq ad-return-value ...) my-mode ad-return-value)) nil lambda) byte-compile-lambda((lambda (n) "$ad-doc: next-history-element$" (interactive "p") (let (ad-return-value) (setq ad-return-value ...) my-mode ad-return-value))) #[nil "??? \n \f ?? 7. `C-x C-c' You will get a pop-up message with Yes/No buttons that says this: Emacs Abort Dialog "A fatal error has occurred! Would you like to attach a debugger? Select YES to debu, NO to abort Emacs" If you select Yes, you get a Window program exception and an invitation to send the details to Microsoft. The error report contents are these: Exception Information Code 0x80000003 Flags: 0x00000000 Record: 0x0000000000000000 (didn't count 'em) Address: 0x0000000077f75a58 System Information Windows NT 5.1 Build: 2600 CPU Vendor Code etc. blah blah blah Module 1 emacs.exe blah blah Module 2 ntdll.dll blah blah Module 3 kernel32.dll blah blah Module 4 msvcrt.dll blah blah etc. etc. ------------------------------------ In GNU Emacs 22.0.50.1 (i386-mingw-nt5.1.2600) of 2005-06-26 on NONIQPC X server distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.3) --cflags -I../../jpeg-6b-3/include -I../../libpng-1.2.8/include -I../../tiff-3.6.1-2/include -I../../xpm-nox-4.2.0/include -I../../zlib-1.2.2/include' _______________________________________________ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug ------- End of forwarded message -------