From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: Problem with revert-buffer and overlays Date: Mon, 28 Nov 2005 16:00:51 -0500 Message-ID: References: <43871059.9090705@gmx.at> <438AD957.4010005@gmx.at> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1133211919 22353 80.91.229.2 (28 Nov 2005 21:05:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 28 Nov 2005 21:05:19 +0000 (UTC) Cc: emacs-devel@gnu.org, storm@cua.dk Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 28 22:05:16 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Egq84-0003pA-Mt for ged-emacs-devel@m.gmane.org; Mon, 28 Nov 2005 22:01:41 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Egq83-0004Hi-V0 for ged-emacs-devel@m.gmane.org; Mon, 28 Nov 2005 16:01:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Egq7p-0004GT-Sp for emacs-devel@gnu.org; Mon, 28 Nov 2005 16:01:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Egq7o-0004Fk-NF for emacs-devel@gnu.org; Mon, 28 Nov 2005 16:01:25 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Egq7o-0004Fg-Hv for emacs-devel@gnu.org; Mon, 28 Nov 2005 16:01:24 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Egq7o-0004gU-7c for emacs-devel@gnu.org; Mon, 28 Nov 2005 16:01:24 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1Egq7H-0000OF-96; Mon, 28 Nov 2005 16:00:52 -0500 Original-To: martin rudalics In-reply-to: <438AD957.4010005@gmx.at> (message from martin rudalics on Mon, 28 Nov 2005 11:17:59 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46724 Archived-At: Why not do this in kill-all-local-variables then? The reason to get rid of the overlays after revert is because they cannot reliably point to the right place any more. Changing the major mode should not delete the overlays--that would be incorrect. (Some might be used by minor modes or other features.) Instead, the major mode should explicitly delete the overlays that it uses. Deactivating the mark would have to be done by insert-file-contents if it finds out that the mark has been invalidated during reversion. I'd leave this alone until someone complains. I just tried it and revert-buffer did deactivate the mark. Can someone describe a test case where it fails to do so?