From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: add-log.el Date: Sat, 29 Oct 2005 01:13:33 -0400 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1130563050 9281 80.91.229.2 (29 Oct 2005 05:17:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 29 Oct 2005 05:17:30 +0000 (UTC) Cc: quarl@cs.berkeley.edu, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 29 07:17:08 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EVj5U-0003yE-AH for ged-emacs-devel@m.gmane.org; Sat, 29 Oct 2005 07:17:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EVj5S-0005JO-GH for ged-emacs-devel@m.gmane.org; Sat, 29 Oct 2005 01:17:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EVj27-0003f8-2Y for emacs-devel@gnu.org; Sat, 29 Oct 2005 01:13:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EVj26-0003ed-7P for emacs-devel@gnu.org; Sat, 29 Oct 2005 01:13:34 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EVj25-0003eZ-Uz for emacs-devel@gnu.org; Sat, 29 Oct 2005 01:13:34 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EVj25-0006sl-W5 for emacs-devel@gnu.org; Sat, 29 Oct 2005 01:13:34 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1EVj25-0000Eq-F5; Sat, 29 Oct 2005 01:13:33 -0400 Original-To: snogglethorpe@gmail.com, miles@gnu.org In-reply-to: (message from Miles Bader on Fri, 28 Oct 2005 21:28:08 +0900) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:45067 Archived-At: > +(defcustom add-log-indent-text 0 > + "*How many spaces to indent subsequent lines in a change entry." It doesn't seem correct to set this sort of parameter using defcustom -- the proper value depends on the _file_ not the user. I tend to agree that this should be an ordinary defvar, not a defcustom. But there are other variables for which arguably the same thing is the case: add-log-time-format, and add-log-keep-changes-together. Should they be changed to defvars? The first, perhaps nobody ever thinks of changing. The second, perhaps is a matter of personal preference as well as a matter of each file's convention. If we leave them as defcustoms, maybe this one should be a defcustom too, just for regularity. What about making a derived-mode that derives from change-log-mode and overrides only that one parameter? That would be much more cumbersome than setting the variable in an ordinary local variables list.