From: "Richard M. Stallman" <rms@gnu.org>
Cc: quarl@cs.berkeley.edu, emacs-devel@gnu.org
Subject: Re: add-log.el
Date: Sat, 29 Oct 2005 01:13:33 -0400 [thread overview]
Message-ID: <E1EVj25-0000Eq-F5@fencepost.gnu.org> (raw)
In-Reply-To: <fc339e4a0510280528u1898ef03s@mail.gmail.com> (message from Miles Bader on Fri, 28 Oct 2005 21:28:08 +0900)
> +(defcustom add-log-indent-text 0
> + "*How many spaces to indent subsequent lines in a change entry."
It doesn't seem correct to set this sort of parameter using defcustom
-- the proper value depends on the _file_ not the user.
I tend to agree that this should be an ordinary defvar, not a
defcustom.
But there are other variables for which arguably the same thing is the
case: add-log-time-format, and add-log-keep-changes-together. Should
they be changed to defvars?
The first, perhaps nobody ever thinks of changing. The second,
perhaps is a matter of personal preference as well as a matter of each
file's convention.
If we leave them as defcustoms, maybe this one should be a defcustom
too, just for regularity.
What about making a derived-mode that derives from change-log-mode and
overrides only that one parameter?
That would be much more cumbersome than setting the variable
in an ordinary local variables list.
next prev parent reply other threads:[~2005-10-29 5:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-28 11:16 add-log.el Karl Chen
2005-10-28 12:28 ` add-log.el Miles Bader
2005-10-28 13:16 ` add-log.el Karl Chen
2005-10-28 13:28 ` add-log.el Karl Chen
2005-10-29 5:13 ` Richard M. Stallman [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-16 17:15 add-log.el Sebastian Rose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1EVj25-0000Eq-F5@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=quarl@cs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).