unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kenichi Handa <handa@m17n.org>
Cc: storm@cua.dk, emacs-devel@gnu.org
Subject: Re: Suspicious code in search.c
Date: Fri, 21 Oct 2005 11:27:21 +0900	[thread overview]
Message-ID: <E1ESmcr-0006xN-00@etlken> (raw)
In-Reply-To: <17240.19436.738186.836546@kahikatea.snap.net.nz> (message from Nick Roberts on Fri, 21 Oct 2005 15:01:16 +1300)

In article <17240.19436.738186.836546@kahikatea.snap.net.nz>, Nick Roberts <nickrob@snap.net.nz> writes:
> The original expression is equivalent to:

>  	  else if ((charset_base
>  		   && (pat_end - ptr) == 1) || CHAR_HEAD_P (ptr[1]))

> I don't know which expression is right, but you've changed the logic.

Oops, you are right.  I misunderstood.  Yes, I changed the
logic and I think the change is correct.  This is the place
to check if *ptr is the last byte of a multibyte character.
It is so if *ptr is the last byte of the whole text or
ptr[1] is the first byte of a character.

---
Kenichi Handa
handa@m17n.org

      reply	other threads:[~2005-10-21  2:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-20 14:52 Suspicious code in search.c Kim F. Storm
2005-10-20 23:38 ` Richard M. Stallman
2005-10-21  0:52   ` Kenichi Handa
2005-10-21 17:51     ` Richard M. Stallman
2005-10-21  0:46 ` Kenichi Handa
2005-10-21  2:01   ` Nick Roberts
2005-10-21  2:27     ` Kenichi Handa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1ESmcr-0006xN-00@etlken \
    --to=handa@m17n.org \
    --cc=emacs-devel@gnu.org \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).