From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Suspicious code in search.c Date: Fri, 21 Oct 2005 09:46:32 +0900 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1129855679 28416 80.91.229.2 (21 Oct 2005 00:47:59 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 21 Oct 2005 00:47:59 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 21 02:47:51 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ESl4C-0001Kk-Ka for ged-emacs-devel@m.gmane.org; Fri, 21 Oct 2005 02:47:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ESl4C-0005IX-2L for ged-emacs-devel@m.gmane.org; Thu, 20 Oct 2005 20:47:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ESl3k-0005HD-Da for emacs-devel@gnu.org; Thu, 20 Oct 2005 20:47:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ESl3g-0005F8-Ur for emacs-devel@gnu.org; Thu, 20 Oct 2005 20:46:58 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ESl3g-0005Ej-0O for emacs-devel@gnu.org; Thu, 20 Oct 2005 20:46:56 -0400 Original-Received: from [192.47.44.130] (helo=tsukuba.m17n.org) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1ESl3f-0001WQ-SI for emacs-devel@gnu.org; Thu, 20 Oct 2005 20:46:56 -0400 Original-Received: from nfs.m17n.org (nfs.m17n.org [192.47.44.7]) by tsukuba.m17n.org (8.13.4/8.13.4/Debian-3) with ESMTP id j9L0kY4v026891; Fri, 21 Oct 2005 09:46:34 +0900 Original-Received: from etlken (etlken.m17n.org [192.47.44.125]) by nfs.m17n.org (8.13.4/8.13.4/Debian-3) with ESMTP id j9L0kYgO013428; Fri, 21 Oct 2005 09:46:34 +0900 Original-Received: from handa by etlken with local (Exim 3.36 #1 (Debian)) id 1ESl3I-00065J-00; Fri, 21 Oct 2005 09:46:32 +0900 Original-To: storm@cua.dk (Kim F. Storm) In-reply-to: (storm@cua.dk) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/22.0.50 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:44461 Archived-At: In article , storm@cua.dk (Kim F. Storm) writes: > See search.c line 1711-1712: > if (ASCII_BYTE_P (*ptr) || ! multibyte) > ch = *ptr; --> else if (charset_base --> && (pat_end - ptr) == 1 || CHAR_HEAD_P (ptr[1])) > { > unsigned char *charstart = ptr - 1; > Based on the indentation, I would assume the following interpretation > is intended: > else if (charset_base > && ((pat_end - ptr) == 1 || CHAR_HEAD_P (ptr[1]))) > ^ ^ Yes, and a compiler should interpret that part as above. But, I agree that it's better to add that explicit parentheses. > Can somebody who knows this code better than I take a look (and > perhaps reformat the code if the current code is ok). Done. --- Kenichi Handa handa@m17n.org