From: Kenichi Handa <handa@m17n.org>
Cc: emacs-devel@gnu.org
Subject: Re: Suspicious code in search.c
Date: Fri, 21 Oct 2005 09:46:32 +0900 [thread overview]
Message-ID: <E1ESl3I-00065J-00@etlken> (raw)
In-Reply-To: <m37jc8i6l1.fsf@kfs-l.imdomain.dk> (storm@cua.dk)
In article <m37jc8i6l1.fsf@kfs-l.imdomain.dk>, storm@cua.dk (Kim F. Storm) writes:
> See search.c line 1711-1712:
> if (ASCII_BYTE_P (*ptr) || ! multibyte)
> ch = *ptr;
--> else if (charset_base
--> && (pat_end - ptr) == 1 || CHAR_HEAD_P (ptr[1]))
> {
> unsigned char *charstart = ptr - 1;
> Based on the indentation, I would assume the following interpretation
> is intended:
> else if (charset_base
> && ((pat_end - ptr) == 1 || CHAR_HEAD_P (ptr[1])))
> ^ ^
Yes, and a compiler should interpret that part as above.
But, I agree that it's better to add that explicit parentheses.
> Can somebody who knows this code better than I take a look (and
> perhaps reformat the code if the current code is ok).
Done.
---
Kenichi Handa
handa@m17n.org
next prev parent reply other threads:[~2005-10-21 0:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-20 14:52 Suspicious code in search.c Kim F. Storm
2005-10-20 23:38 ` Richard M. Stallman
2005-10-21 0:52 ` Kenichi Handa
2005-10-21 17:51 ` Richard M. Stallman
2005-10-21 0:46 ` Kenichi Handa [this message]
2005-10-21 2:01 ` Nick Roberts
2005-10-21 2:27 ` Kenichi Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1ESl3I-00065J-00@etlken \
--to=handa@m17n.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).