ispell.el doesn't work any more

ispell.el doesn't work any more

[Stefan Monnier]

Now whenever I try to run flyspell-mode (which I use pretty much
everywhere), I get the following backtrace:

Indeed, my aspell is older than 0.60, but it worked just fine until now.
It's not like Fedora Core 2 is ancient.  It's not the latest and greatest,
but it should definitely be among the systems that we still support.


        Stefan


Debugger entered--Lisp error: (error "aspell version 0.60 or greater is required")
  signal(error ("aspell version 0.60 or greater is required"))
  error("aspell version 0.60 or greater is required")
  ispell-check-version()
  ispell-init-process()
  ispell-buffer-local-words()
  ispell-accept-buffer-local-defs()
  flyspell-accept-buffer-local-defs()
  flyspell-mode-on()
  flyspell-mode(1)
  (if (and (fboundp ...) (fboundp ...) (executable-find "ispell")) (flyspell-mode 1))
  sm-text-mode-hook()
  run-hooks(text-mode-hook message-mode-hook)
  apply(run-hooks (text-mode-hook message-mode-hook))
  run-mode-hooks(message-mode-hook)
  message-mode()
  message-pop-to-buffer("*mail to emacs-devel@gnu.org*")
  message-mail("emacs-devel@gnu.org")
  gnus-post-news(post "nnimap+diro:emacs" nil nil nil nil nil)
  gnus-group-post-news((4))
  call-interactively(gnus-group-post-news nil nil)

Re: ispell.el doesn't work any more

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 12 Sep 2005 12:22:54 -0400
> 
> Now whenever I try to run flyspell-mode (which I use pretty much
> everywhere), I get the following backtrace:
> 
> Indeed, my aspell is older than 0.60, but it worked just fine until now.
> It's not like Fedora Core 2 is ancient.  It's not the latest and greatest,
> but it should definitely be among the systems that we still support.
> 
> 
>         Stefan
> 
> 
> Debugger entered--Lisp error: (error "aspell version 0.60 or greater is required")
>   signal(error ("aspell version 0.60 or greater is required"))
>   error("aspell version 0.60 or greater is required")

This is due to a change I installed yesterday (per Richard's request)
which explicitly rejects Aspell versions older than 0.60.

I don't know why older Aspell's are no good for us.  Magnus, can you
please comment on that?

Re: ispell.el doesn't work any more

[Magnus Henoch]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> I don't know why older Aspell's are no good for us.  Magnus, can you
> please comment on that?

The main cause is that aspell >= 0.60 consistently supports UTF-8,
which simplifies the automatic dictionary detection.  Supporting
aspell 0.50 would involve either looking for "charset" declarations in
in ispell-aspell-find-dictionary, or disabling the dictionary finding
and relying on the value of ispell-dictionary-alist.

The latter would be something like this patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Disable dictionary finding for aspell < 0.60 --]
[-- Type: text/x-patch, Size: 1298 bytes --]

--- orig/lisp/textmodes/ispell.el
+++ mod/lisp/textmodes/ispell.el
@@ -719,6 +719,12 @@
 
 (defvar ispell-really-aspell nil) ; Non-nil if aspell extensions should be used
 
+(defvar ispell-aspell-supports-utf8 nil
+  "Non-nil means to try to automatically find aspell dictionaries.
+This is set to t in ispell-check-version for aspell >= 0.60.
+
+Earlier aspell versions do not consistently support UTF-8.  Handling
+this would require some extra guessing in `ispell-aspell-find-dictionary'.")
 
 
 
@@ -815,8 +821,9 @@
         (let (case-fold-search)
           (setq ispell-really-aspell
 		(and (search-forward-regexp "(but really Aspell \\(.*\\))" nil t)
-		     (if (version< (match-string 1) "0.60")
-			 (error "aspell version 0.60 or greater is required")
+		     (progn
+		       (setq ispell-aspell-supports-utf8
+			     (not (version< (match-string 1) "0.60")))
 		       t)))))
       (kill-buffer (current-buffer)))
     result))
@@ -972,7 +979,8 @@
 	     (condition-case ()
 		 (progn (ispell-check-version) t)
 	       (error nil))
-	     ispell-really-aspell)
+	     ispell-really-aspell
+	     ispell-aspell-supports-utf8)
     (ispell-find-aspell-dictionaries))
   (let ((dicts (append ispell-local-dictionary-alist ispell-dictionary-alist))
 	(dict-list (cons "default" nil))

[-- Attachment #3: Type: text/plain, Size: 181 bytes --]


Other than that, minor details and risk of bit rot.  E.g. 0.50 accepts
"-l" as an alias of "list", while 0.60 does not (this was fixed in
flyspell a couple of months ago).

Magnus

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: ispell.el doesn't work any more

[Stefan Monnier]

>> I don't know why older Aspell's are no good for us.  Magnus, can you
>> please comment on that?

> The main cause is that aspell >= 0.60 consistently supports UTF-8,
> which simplifies the automatic dictionary detection.  Supporting
> aspell 0.50 would involve either looking for "charset" declarations in
> in ispell-aspell-find-dictionary, or disabling the dictionary finding
> and relying on the value of ispell-dictionary-alist.

> The latter would be something like this patch:

IIUC, this patch would let older aspell use the old elisp code (which
worked just fine, except it wasn't able to figure out which dictionaries
are installed, so it used a default heuristic list)?
Sounds good to me,


        Stefan


> --- orig/lisp/textmodes/ispell.el
> +++ mod/lisp/textmodes/ispell.el
> @@ -719,6 +719,12 @@
 
>  (defvar ispell-really-aspell nil) ; Non-nil if aspell extensions should be used
 
> +(defvar ispell-aspell-supports-utf8 nil
> +  "Non-nil means to try to automatically find aspell dictionaries.
> +This is set to t in ispell-check-version for aspell >= 0.60.
> +
> +Earlier aspell versions do not consistently support UTF-8.  Handling
> +this would require some extra guessing in `ispell-aspell-find-dictionary'.")
 
 
 
> @@ -815,8 +821,9 @@
>          (let (case-fold-search)
>            (setq ispell-really-aspell
>  		(and (search-forward-regexp "(but really Aspell \\(.*\\))" nil t)
> -		     (if (version< (match-string 1) "0.60")
> -			 (error "aspell version 0.60 or greater is required")
> +		     (progn
> +		       (setq ispell-aspell-supports-utf8
> +			     (not (version< (match-string 1) "0.60")))
>  		       t)))))
>        (kill-buffer (current-buffer)))
>      result))
> @@ -972,7 +979,8 @@
>  	     (condition-case ()
>  		 (progn (ispell-check-version) t)
>  	       (error nil))
> -	     ispell-really-aspell)
> +	     ispell-really-aspell
> +	     ispell-aspell-supports-utf8)
>      (ispell-find-aspell-dictionaries))
>    (let ((dicts (append ispell-local-dictionary-alist ispell-dictionary-alist))
>  	(dict-list (cons "default" nil))


> Other than that, minor details and risk of bit rot.  E.g. 0.50 accepts
> "-l" as an alias of "list", while 0.60 does not (this was fixed in
> flyspell a couple of months ago).

> Magnus

> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: ispell.el doesn't work any more

[Richard M. Stallman]

    Supporting
    aspell 0.50 would involve either looking for "charset" declarations in
    in ispell-aspell-find-dictionary, or disabling the dictionary finding
    and relying on the value of ispell-dictionary-alist.

    The latter would be something like this patch:

That approach seems good to me.  It will work with aspell 0.50 as
well as it would have worked with ispell.

Does anyone see a problem with that patch?

Re: ispell.el doesn't work any more

[Juri Linkov]

> That approach seems good to me.  It will work with aspell 0.50 as
> well as it would have worked with ispell.
>
> Does anyone see a problem with that patch?

This patch seems good for versions older than 0.60, but now I get
another error for version numbers greater than 0.60:

Debugger entered--Lisp error: (error "Invalid version syntax: '0.60.3-20050121'")
  signal(error ("Invalid version syntax: '0.60.3-20050121'"))
  error("Invalid version syntax: '%s'" "0.60.3-20050121")
  version-to-list("0.60.3-20050121")
  version<("0.60.3-20050121" "0.60")
  ispell-check-version()
  ispell-init-process()
  ispell-buffer-local-words()
  ispell-accept-buffer-local-defs()
  ispell-word(nil nil nil)
  call-interactively(ispell-word)

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: ispell.el doesn't work any more

[Eli Zaretskii]

> From: Juri Linkov <juri@jurta.org>
> Date: Fri, 16 Sep 2005 01:01:48 +0300
> Cc: mange@freemail.hu, emacs-devel@gnu.org
> 
> > That approach seems good to me.  It will work with aspell 0.50 as
> > well as it would have worked with ispell.
> >
> > Does anyone see a problem with that patch?
> 
> This patch seems good for versions older than 0.60, but now I get
> another error for version numbers greater than 0.60:
> 
> Debugger entered--Lisp error: (error "Invalid version syntax: '0.60.3-20050121'")
>   signal(error ("Invalid version syntax: '0.60.3-20050121'"))
>   error("Invalid version syntax: '%s'" "0.60.3-20050121")
>   version-to-list("0.60.3-20050121")
>   version<("0.60.3-20050121" "0.60")
>   ispell-check-version()
>   ispell-init-process()
>   ispell-buffer-local-words()
>   ispell-accept-buffer-local-defs()
>   ispell-word(nil nil nil)
>   call-interactively(ispell-word)

That's because version-to-list doesn't support this syntax of version
numbers.  In addition, it isn't case-insensitive to strings it does
support, like "alpha".

So how about the following patch, which fixes the case-fold issue,
improves the doc string, and extends the valid syntax for version
numbers?

Index: lisp/subr.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/subr.el,v
retrieving revision 1.478
diff -u -r1.478 subr.el
--- lisp/subr.el	26 Aug 2005 12:31:55 -0000	1.478
+++ lisp/subr.el	17 Sep 2005 10:52:52 -0000
@@ -2862,9 +2862,11 @@
 
 
 (defvar version-regexp-alist
-  '(("^a\\(lpha\\)?$"   . -3)
-    ("^b\\(eta\\)?$"    . -2)
-    ("^\\(pre\\|rc\\)$" . -1))
+  '(("^[-_]?a\\(lpha\\)?$"   . -3)
+    ("^[-_]$" . -3)	; treat "1.2.3-20050920" and "1.2-3" as alpha releases
+    ("^[-_]cvs$" . -3)	; treat "1.2.3-CVS" as alpha release
+    ("^[-_]?b\\(eta\\)?$"    . -2)
+    ("^[-_]?\\(pre\\|rc\\)$" . -1))
   "*Specify association between non-numeric version part and a priority.
 
 This association is used to handle version string like \"1.0pre2\",
@@ -2887,6 +2889,9 @@
 Where:
 
 REGEXP		regexp used to match non-numeric part of a version string.
+       	It should begin with a `^' anchor and end with a `$' to
+       	prevent false hits.  Letter-case is ignored while matching
+       	REGEXP.
 
 PRIORITY	negative integer which indicate the non-numeric priority.")
 
@@ -2903,9 +2908,12 @@
    SEPARATOR ::= `version-separator' (which see)
 	       | `version-regexp-alist' (which see).
 
+The NUMBER part is optional if SEPARATOR is a match for an element
+in `version-regexp-alist'.
+
 As an example of valid version syntax:
 
-   1.0pre2   1.0.7.5   22.8beta3   0.9alpha1
+   1.0pre2   1.0.7.5   22.8beta3   0.9alpha1   6.9.30Beta
 
 As an example of invalid version syntax:
 
@@ -2928,7 +2936,7 @@
       (error "Invalid version string: '%s'" ver))
   (save-match-data
     (let ((i 0)
-	  case-fold-search		; ignore case in matching
+	  (case-fold-search t)		; ignore case in matching
 	  lst s al)
       (while (and (setq s (string-match "[0-9]+" ver i))
 		  (= s i))

Re: ispell.el doesn't work any more

[Eli Zaretskii]

> From: Juri Linkov <juri@jurta.org>
> Date: Fri, 16 Sep 2005 01:01:48 +0300
> Cc: mange@freemail.hu, emacs-devel@gnu.org
> 
> > That approach seems good to me.  It will work with aspell 0.50 as
> > well as it would have worked with ispell.
> >
> > Does anyone see a problem with that patch?
> 
> This patch seems good for versions older than 0.60, but now I get
> another error for version numbers greater than 0.60:
> 
> Debugger entered--Lisp error: (error "Invalid version syntax: '0.60.3-20050121'")
>   signal(error ("Invalid version syntax: '0.60.3-20050121'"))
>   error("Invalid version syntax: '%s'" "0.60.3-20050121")
>   version-to-list("0.60.3-20050121")
>   version<("0.60.3-20050121" "0.60")
>   ispell-check-version()
>   ispell-init-process()
>   ispell-buffer-local-words()
>   ispell-accept-buffer-local-defs()
>   ispell-word(nil nil nil)
>   call-interactively(ispell-word)

That's because version-to-list doesn't support this syntax of version
numbers.  In addition, it isn't case-insensitive to strings it does
support, like "alpha".

So how about the following patch, which fixes the case-fold issue,
improves the doc string, and extends the valid syntax for version
numbers?

Index: lisp/subr.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/subr.el,v
retrieving revision 1.478
diff -u -r1.478 subr.el
--- lisp/subr.el	26 Aug 2005 12:31:55 -0000	1.478
+++ lisp/subr.el	17 Sep 2005 10:52:52 -0000
@@ -2862,9 +2862,11 @@
 
 
 (defvar version-regexp-alist
-  '(("^a\\(lpha\\)?$"   . -3)
-    ("^b\\(eta\\)?$"    . -2)
-    ("^\\(pre\\|rc\\)$" . -1))
+  '(("^[-_]?a\\(lpha\\)?$"   . -3)
+    ("^[-_]$" . -3)	; treat "1.2.3-20050920" and "1.2-3" as alpha releases
+    ("^[-_]cvs$" . -3)	; treat "1.2.3-CVS" as alpha release
+    ("^[-_]?b\\(eta\\)?$"    . -2)
+    ("^[-_]?\\(pre\\|rc\\)$" . -1))
   "*Specify association between non-numeric version part and a priority.
 
 This association is used to handle version string like \"1.0pre2\",
@@ -2887,6 +2889,9 @@
 Where:
 
 REGEXP		regexp used to match non-numeric part of a version string.
+       	It should begin with a `^' anchor and end with a `$' to
+       	prevent false hits.  Letter-case is ignored while matching
+       	REGEXP.
 
 PRIORITY	negative integer which indicate the non-numeric priority.")
 
@@ -2903,9 +2908,12 @@
    SEPARATOR ::= `version-separator' (which see)
 	       | `version-regexp-alist' (which see).
 
+The NUMBER part is optional if SEPARATOR is a match for an element
+in `version-regexp-alist'.
+
 As an example of valid version syntax:
 
-   1.0pre2   1.0.7.5   22.8beta3   0.9alpha1
+   1.0pre2   1.0.7.5   22.8beta3   0.9alpha1   6.9.30Beta
 
 As an example of invalid version syntax:
 
@@ -2928,7 +2936,7 @@
       (error "Invalid version string: '%s'" ver))
   (save-match-data
     (let ((i 0)
-	  case-fold-search		; ignore case in matching
+	  (case-fold-search t)		; ignore case in matching
 	  lst s al)
       (while (and (setq s (string-match "[0-9]+" ver i))
 		  (= s i))

Re: ispell.el doesn't work any more

[Juri Linkov]

> So how about the following patch, which fixes the case-fold issue,
> improves the doc string, and extends the valid syntax for version
> numbers?

Your patch works for aspell version 0.60.3-20050121.

I also suggest to add another quite common separator `+' to the
set of separators `[-_]' in version-regexp-alist.

But what to do for aspell version formats not supported even with your
patch?  Various distributions can modify the version string to arbitrary
formats.  I think ispell.el should fail gracefully in the case of
unsupported version formats.

To do this, the default value of ispell-aspell-supports-utf8 could be
`auto-detect', so users will be able to set it explicitly to `nil' or `t',
if version testing fails (with `condition-case' around the testing code).

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: ispell.el doesn't work any more

[Luc Teirlinck]

Juri Linkov wrote:

   But what to do for aspell version formats not supported even with your
   patch?

In particular, after applying Eli's patch, I still get:

version-to-list: Invalid version syntax: '.33.7 alpha'

(After `M-x ispell-buffer'.)

Sincerely,

Luc.

Re: ispell.el doesn't work any more

[Eli Zaretskii]

> Date: Tue, 20 Sep 2005 09:32:11 -0500 (CDT)
> From: Luc Teirlinck <teirllm@dms.auburn.edu>
> CC: eliz@gnu.org, mange@freemail.hu, emacs-devel@gnu.org
> 
> Juri Linkov wrote:
> 
>    But what to do for aspell version formats not supported even with your
>    patch?
> 
> In particular, after applying Eli's patch, I still get:
> 
> version-to-list: Invalid version syntax: '.33.7 alpha'
> 
> (After `M-x ispell-buffer'.)

What version is that (what is the precise version string it reports),
and of which speller?

Re: ispell.el doesn't work any more

[Luc Teirlinck]

Eli Zaretskii wrote:

   What version is that (what is the precise version string it reports),
   and of which speller?

[bash3.00.0 ~ 3 2] ispell -v       
@(#) International Ispell Version 3.1.20 (but really Aspell .33.7 alpha)

Sincerely,

Luc.

Re: ispell.el doesn't work any more

[Eli Zaretskii]

> Date: Tue, 20 Sep 2005 15:56:46 -0500 (CDT)
> From: Luc Teirlinck <teirllm@dms.auburn.edu>
> CC: juri@jurta.org, mange@freemail.hu, emacs-devel@gnu.org
> 
> Eli Zaretskii wrote:
> 
>    What version is that (what is the precise version string it reports),
>    and of which speller?
> 
> [bash3.00.0 ~ 3 2] ispell -v       
> @(#) International Ispell Version 3.1.20 (but really Aspell .33.7 alpha)

If aspell indeed reports ".33.7 alpha" as its version string, I
suggest to talk to aspell maintainers to change that to something more
reasonable.

Re: ispell.el doesn't work any more

[Eli Zaretskii]

> From: Juri Linkov <juri@jurta.org>
> Cc: mange@freemail.hu, emacs-devel@gnu.org
> Date: Tue, 20 Sep 2005 08:07:09 +0300
> 
> > So how about the following patch, which fixes the case-fold issue,
> > improves the doc string, and extends the valid syntax for version
> > numbers?
> 
> Your patch works for aspell version 0.60.3-20050121.

Thanks, I will install it soon.

> I also suggest to add another quite common separator `+' to the
> set of separators `[-_]' in version-regexp-alist.

Will do.

> But what to do for aspell version formats not supported even with your
> patch?  Various distributions can modify the version string to arbitrary
> formats.

The point of my patch was to extend version-to-list, not just to fix
ispell.el.  If we want a general-purpose version string handler, we
need to support as many version string formats as we can.

> I think ispell.el should fail gracefully in the case of
> unsupported version formats.

Yes, I agree.

Re: ispell.el doesn't work any more

[Eli Zaretskii]

> Date: Tue, 20 Sep 2005 22:13:40 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: mange@freemail.hu, emacs-devel@gnu.org
> 
> > From: Juri Linkov <juri@jurta.org>
> > Cc: mange@freemail.hu, emacs-devel@gnu.org
> > Date: Tue, 20 Sep 2005 08:07:09 +0300
> > 
> > > So how about the following patch, which fixes the case-fold issue,
> > > improves the doc string, and extends the valid syntax for version
> > > numbers?
> > 
> > Your patch works for aspell version 0.60.3-20050121.
> 
> Thanks, I will install it soon.

Done.

Re: ispell.el doesn't work any more

[Eli Zaretskii]

> From: Magnus Henoch <mange@freemail.hu>
> Date: Tue, 13 Sep 2005 00:29:04 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I don't know why older Aspell's are no good for us.  Magnus, can you
> > please comment on that?
> 
> The main cause is that aspell >= 0.60 consistently supports UTF-8,
> which simplifies the automatic dictionary detection.  Supporting
> aspell 0.50 would involve either looking for "charset" declarations in
> in ispell-aspell-find-dictionary, or disabling the dictionary finding
> and relying on the value of ispell-dictionary-alist.
> 
> The latter would be something like this patch:

Thanks, I installed it.