Calendar, diary, and diary-mode

Calendar, diary, and diary-mode

[Stefan Monnier]

How is diary-mode used?  It's defined and seems to work if I call it
manually, but it's not directly used anywhere.  WAIM?


        Stefan

Re: Calendar, diary, and diary-mode

[Karl Chen]

>>>>> On 2005-09-05 12:03 PDT, Stefan Monnier writes:

    Stefan> How is diary-mode used?  It's defined and seems to
    Stefan> work if I call it manually, but it's not directly used
    Stefan> anywhere.  WAIM?

There are at least two functions that do basically
(find-file-noselect (diary-check-diary-file) t).  It might be a
good idea to refactor this, creating a function that returns the
buffer for the diary file, setting major-mode, etc. when opening.

-- 
Karl 2005-09-06 01:07

Re: Calendar, diary, and diary-mode

[Stefan Monnier]

Stefan> How is diary-mode used?  It's defined and seems to
Stefan> work if I call it manually, but it's not directly used
Stefan> anywhere.  WAIM?

> There are at least two functions that do basically
> (find-file-noselect (diary-check-diary-file) t).  It might be a
> good idea to refactor this, creating a function that returns the
> buffer for the diary file, setting major-mode, etc. when opening.

Yes, that's pretty much what I do, locally, but it's obvious enough that I'd
like to hear how the current code is actually used.

diary-lib.el has many other oddities.  E.g. it passes diary-file through
substitute-in-file-name sometimes, but not always.


        Stefan

Re: Calendar, diary, and diary-mode

[Richard M. Stallman]

    There are at least two functions that do basically
    (find-file-noselect (diary-check-diary-file) t).  It might be a
    good idea to refactor this, creating a function that returns the
    buffer for the diary file, setting major-mode, etc. when opening.

That might not be a bad change.  But if there's nothing broken here,
I'd rather we leave well enough alone, and focus our attention on
other areas where changes would produce real benefit.
Have you looked at etc/TODO?