* prefixes and enable-theme, ...
@ 2005-09-05 18:40 Stefan Monnier
2005-09-05 18:56 ` Luc Teirlinck
2005-09-06 5:29 ` Richard M. Stallman
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Monnier @ 2005-09-05 18:40 UTC (permalink / raw)
I see that some custom-theme functions have been renamed:
require-theme -> load-theme
custom-enable-theme -> enable-theme
custom-disable-theme -> disable-theme
I know that a good bit of the "core" Emacs functionality doesn't follow the
coding convention that requires the use of unique prefixes in variables and
function names. But I think it'd be good to try and avoid making this any
worse than it already is.
So I suggest we either keep the old "custom-..." names or otherwise switch to:
theme-require
theme-enable
theme-disable
theme-provide
-- Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: prefixes and enable-theme, ...
2005-09-05 18:40 prefixes and enable-theme, Stefan Monnier
@ 2005-09-05 18:56 ` Luc Teirlinck
2005-09-05 18:59 ` Stefan Monnier
2005-09-06 5:29 ` Richard M. Stallman
1 sibling, 1 reply; 4+ messages in thread
From: Luc Teirlinck @ 2005-09-05 18:56 UTC (permalink / raw)
Cc: emacs-devel
Stefan Monnier wrote:
I see that some custom-theme functions have been renamed:
require-theme -> load-theme
If I remember well that was not just a renaming. The function was
changed from a `require-type' behavior (load if not already loaded)
to `load-type' behavior (unconditional loading).
Sincerely,
Luc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: prefixes and enable-theme, ...
2005-09-05 18:56 ` Luc Teirlinck
@ 2005-09-05 18:59 ` Stefan Monnier
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2005-09-05 18:59 UTC (permalink / raw)
Cc: emacs-devel
> I see that some custom-theme functions have been renamed:
> require-theme -> load-theme
> If I remember well that was not just a renaming. The function was
> changed from a `require-type' behavior (load if not already loaded)
> to `load-type' behavior (unconditional loading).
Could be: I wasn't talking about that part. I was talking about the lack
of prefix.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: prefixes and enable-theme, ...
2005-09-05 18:40 prefixes and enable-theme, Stefan Monnier
2005-09-05 18:56 ` Luc Teirlinck
@ 2005-09-06 5:29 ` Richard M. Stallman
1 sibling, 0 replies; 4+ messages in thread
From: Richard M. Stallman @ 2005-09-06 5:29 UTC (permalink / raw)
Cc: emacs-devel
`enable-theme' is more natural than `theme-enable'.
I want to stay with that.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-09-06 5:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-05 18:40 prefixes and enable-theme, Stefan Monnier
2005-09-05 18:56 ` Luc Teirlinck
2005-09-05 18:59 ` Stefan Monnier
2005-09-06 5:29 ` Richard M. Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).