From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: Customizing faces with `defcustom' Date: Thu, 01 Sep 2005 11:53:27 -0400 Message-ID: References: <43103F48.1020804@gmx.at> <4313F4CB.10200@gmx.at> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1125590993 18418 80.91.229.2 (1 Sep 2005 16:09:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 1 Sep 2005 16:09:53 +0000 (UTC) Cc: Per Abrahamsen , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 01 18:09:49 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EArZd-0004x5-3s for ged-emacs-devel@m.gmane.org; Thu, 01 Sep 2005 18:05:57 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EArdr-000293-UZ for ged-emacs-devel@m.gmane.org; Thu, 01 Sep 2005 12:10:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EArYg-0007uq-LL for emacs-devel@gnu.org; Thu, 01 Sep 2005 12:05:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EArYZ-0007pp-7i for emacs-devel@gnu.org; Thu, 01 Sep 2005 12:04:52 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EArYX-0007gw-Ci for emacs-devel@gnu.org; Thu, 01 Sep 2005 12:04:49 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EArRM-0000Gx-8i for emacs-devel@gnu.org; Thu, 01 Sep 2005 11:57:24 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1EArNX-0000ep-IM; Thu, 01 Sep 2005 11:53:27 -0400 Original-To: martin rudalics In-reply-to: <4313F4CB.10200@gmx.at> (message from martin rudalics on Tue, 30 Aug 2005 07:55:23 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42558 Archived-At: Consider, for example, the customization buffer for `matching': [Made by M-x customize-group RET matching RET] (1) `match' stands out in `custom-face-tag-face', by default scaled by 1.2 and bold. (2) `list-matching-lines-default-context-lines' is highlighted in `custom-variable-tag-face', by default scaled by 1.2 and bold. Then come the options (3) `list-matching-lines-face' and `list-matching-lines-buffer-name-face' both in default face. That is a real bug. These are variables, and their names should be highlighted like all other variable names. I think this is a consequence of the following definition for widget type `face'. (define-widget 'face 'symbol "A Lisp face name (with sample)." :format "%t: (%{sample%}) %v" :tag "Face" :value 'default :sample-face-get 'widget-face-sample-face-get I think that this :sample-face-get definition is affecting the appearance of the variable's name. The code in the definition of the `face' widget was adapted from the `color' widget. I tried this example (defcustom foocolor "black" "Foo" :type 'color) and saw the same problem occur. I think it is a bug that the :sample-face-get of the type has an effect on display of the variable name. I would expect it to affect only where the value is displayed. But I have never understood the widget code, so I have no idea how this happens. Can anyone figure out how to fix that?