From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Dr Francis J Wright" Newsgroups: gmane.emacs.devel Subject: RE: patch for woman (woman-topic-at-point) Date: Fri, 26 Aug 2005 17:25:58 +0100 Organization: Maths, Queen Mary, University of London Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1125074816 3354 80.91.229.2 (26 Aug 2005 16:46:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 26 Aug 2005 16:46:56 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 26 18:46:53 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1E8hLK-0002Gs-KE for ged-emacs-devel@m.gmane.org; Fri, 26 Aug 2005 18:46:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E8hPG-0002zy-4o for ged-emacs-devel@m.gmane.org; Fri, 26 Aug 2005 12:50:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E8hGX-0000Gp-3D for emacs-devel@gnu.org; Fri, 26 Aug 2005 12:41:17 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E8hGJ-00009u-2P for emacs-devel@gnu.org; Fri, 26 Aug 2005 12:41:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E8hGI-0008Te-JH for emacs-devel@gnu.org; Fri, 26 Aug 2005 12:41:02 -0400 Original-Received: from [138.37.6.6] (helo=mail2.qmul.ac.uk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E8h3M-00012H-LG; Fri, 26 Aug 2005 12:27:40 -0400 Original-Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.43) id 1E8h1l-0003jX-AW; Fri, 26 Aug 2005 17:26:01 +0100 Original-Received: from centaur.maths.qmul.ac.uk ([138.37.80.58] helo=centaur) by smtp.qmul.ac.uk with esmtp (Exim 4.50) id 1E8h1l-00032y-6k; Fri, 26 Aug 2005 17:26:01 +0100 Original-To: , "'Emilio Lopes'" X-Mailer: Microsoft Office Outlook, Build 11.0.6353 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2527 Thread-Index: AcWqNjL4PZOjCUO/TWeQb+T3v9uAtgAI23DA X-Sender-Host-Address: 138.37.80.58 X-QM-Scan-Virus: virusscan says the message is clean X-QM-Scan-Virus: ClamAV says the message is clean X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42434 Archived-At: I prefer Richard's proposal as below. Breaking the line in the doc string for woman-use-symbol-font may well be a good idea, but I would prefer to retain some white space after the comma. Richard: Thanks for sending me the full context separately. Best wishes, Francis > -----Original Message----- > From: Richard M. Stallman [mailto:rms@gnu.org] > Sent: Friday 26 August 2005 1:03 pm > To: Emilio Lopes > Cc: emacs-devel@gnu.org; Francis J. Wright > Subject: Re: patch for woman (woman-topic-at-point) > > The problem is that "to suggest" for `woman' means to actually > *insert* the suggested name in the minibuffer, a behavior > described > as deprecated in the documentation of `completing-read'. > > That is an unnecessarily complex solution. It would be > better just to change *how* that name is offered. Instead of > inserting it in the minibuffer, make it the default, more or > less as below. > > This could be an unconditional change, so it would not > require any options. However, it might also be desirable to > check (perhaps as an > option) whether the name is valid before offering it as the default. > > Your diff includes some other miscellanious fixes, such as > breaking a line in a doc string, which might be good to > install independent of this. > > *** woman.el 07 Aug 2005 13:30:28 -0400 1.33 > --- woman.el 26 Aug 2005 06:02:31 -0400 > *************** > *** 1235,1245 **** > (completing-read > "Manual entry: " > woman-topic-all-completions nil 1 > ;; Initial input suggestion (was nil), with > ;; cursor at left ready to kill suggestion!: > (and woman-topic-at-point > (cons (or (current-word) "") 0)) ; nearest word > ! 'woman-topic-history))) > ;; Note that completing-read always returns a string. > (if (= (length topic) 0) > nil ; no topic, so no file! > --- 1235,1247 ---- > (completing-read > "Manual entry: " > woman-topic-all-completions nil 1 > + nil > + 'woman-topic-history > ;; Initial input suggestion (was nil), with > ;; cursor at left ready to kill suggestion!: > (and woman-topic-at-point > (cons (or (current-word) "") 0)) ; nearest > word ! ))) > ;; Note that completing-read always returns a string. > (if (= (length topic) 0) > nil ; no topic, so no file! >