From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: Custom/define-minor-mode problem Date: Tue, 23 Aug 2005 20:10:00 -0400 Message-ID: References: <20050822182030.28436.qmail@web60318.mail.yahoo.com> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1124843997 7981 80.91.229.2 (24 Aug 2005 00:39:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 24 Aug 2005 00:39:57 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 24 02:39:48 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1E7jHu-0003Fn-LC for ged-emacs-devel@m.gmane.org; Wed, 24 Aug 2005 02:38:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E7jLh-0000PP-Vh for ged-emacs-devel@m.gmane.org; Tue, 23 Aug 2005 20:42:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E7jJm-0000J8-9x for emacs-devel@gnu.org; Tue, 23 Aug 2005 20:40:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E7jJU-0000Eo-W1 for emacs-devel@gnu.org; Tue, 23 Aug 2005 20:40:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E7jJU-00005G-EQ for emacs-devel@gnu.org; Tue, 23 Aug 2005 20:40:20 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E7ir5-0002P6-Cw for emacs-devel@gnu.org; Tue, 23 Aug 2005 20:10:59 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1E7iq8-00064Y-H2; Tue, 23 Aug 2005 20:10:00 -0400 Original-To: Michael Mauger In-reply-to: <20050822182030.28436.qmail@web60318.mail.yahoo.com> (message from Michael Mauger on Mon, 22 Aug 2005 11:20:30 -0700 (PDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42372 Archived-At: There was no feedback on this. The problem could arise with any minor mode that has customized variables. If no one objects, could it be comitted? I can't access the repository now, but it looks like you want to revert the following change: 2005-06-26 Stefan Monnier * emacs-lisp/easy-mmode.el (define-minor-mode): Don't automatically add a :require to the defcustom. I don't remember the precise details of the bug that that change fixed, but it certainly fixed one. So your change is definitely not correct. Please do not install it. If there is a new bug to be corrected now, we can't address it properly without considering the old problem at the same time.