* dump-emacs not compatible with toolbar-mode [not found] ` <E1E2bvw-0003pS-BY@fencepost.gnu.org> @ 2005-08-10 3:13 ` Bill Atkins 2005-08-10 3:18 ` Bill Atkins 2005-08-11 14:28 ` Richard M. Stallman 0 siblings, 2 replies; 7+ messages in thread From: Bill Atkins @ 2005-08-10 3:13 UTC (permalink / raw) There is a bug that arises when using dump-emacs to preload your Emacs. It seems that if the function find-image is called at any time before the dump, starting the dumped image will result in an error and startup will halt. I just checked out a fresh copy of Emacs and built it a few hours ago, to make sure the problem is not limited to my own snapshot. Here is the command line I'm using to dump the image: ./src/emacs -q --batch --load bug_trap --execute "(dump-emacs \"resmacs\" \"src/emacs\")" Here are the contents of the bug_trap file: ------ (setq debug-on-error t) (find-image '((:type xpm :file "toolbar/new.xpm" :ascent center))) ------- Since certain packages call find-image directly or indirectly, there are other ways to trigger the error. For instance, loading php-mode.el or time.el before dumping will yield identical results. Here is a backtrace of the error (this results from running "./resmacs -q"): ------- Debugger entered--Lisp error: (error "Invalid image specification") image-mask-p((image :type xpm :file "/home/bill/emacs/lisp/toolbar/new.xpm")) tool-bar-local-item-from-menu(find-file "new" (keymap) nil) apply(tool-bar-local-item-from-menu find-file "new" (keymap) nil nil) tool-bar-add-item-from-menu(find-file "new") tool-bar-setup() tool-bar-mode(1) command-line() normal-top-level() -------- Again, this error _only_ occurs if find-image gets called before the dump. Also, the error does not occur in -nw mode; it only appears when run in X. I'd be happy to provide any clarification. Unfortunately, I'm not familiar enough with Emacs' internals to provide a patch. -- Bill Atkins ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: dump-emacs not compatible with toolbar-mode 2005-08-10 3:13 ` dump-emacs not compatible with toolbar-mode Bill Atkins @ 2005-08-10 3:18 ` Bill Atkins 2005-08-11 14:28 ` Richard M. Stallman 1 sibling, 0 replies; 7+ messages in thread From: Bill Atkins @ 2005-08-10 3:18 UTC (permalink / raw) I should also mention that this happens even if the particular image to be loaded is not toolbar/new.xpm. I use that in bug_trap simply because that's what Emacs was choking on. Once Emacs is running, though, it can load new.xpm and any other valid XPM I've tried without issue. On 8/9/05, Bill Atkins <batkins57@gmail.com> wrote: > There is a bug that arises when using dump-emacs to preload your > Emacs. It seems that if the function find-image is called at any time > before the dump, starting the dumped image will result in an error and > startup will halt. > > I just checked out a fresh copy of Emacs and built it a few hours ago, > to make sure the problem is not limited to my own snapshot. > > Here is the command line I'm using to dump the image: > > ./src/emacs -q --batch --load bug_trap --execute "(dump-emacs > \"resmacs\" \"src/emacs\")" > > Here are the contents of the bug_trap file: > ------ > (setq debug-on-error t) > > (find-image '((:type xpm :file "toolbar/new.xpm" :ascent center))) > ------- > > Since certain packages call find-image directly or indirectly, there > are other ways to trigger the error. For instance, loading > php-mode.el or time.el before dumping will yield identical results. > > Here is a backtrace of the error (this results from running "./resmacs -q"): > > ------- > Debugger entered--Lisp error: (error "Invalid image specification") > image-mask-p((image :type xpm :file "/home/bill/emacs/lisp/toolbar/new.xpm")) > tool-bar-local-item-from-menu(find-file "new" (keymap) nil) > apply(tool-bar-local-item-from-menu find-file "new" (keymap) nil nil) > tool-bar-add-item-from-menu(find-file "new") > tool-bar-setup() > tool-bar-mode(1) > command-line() > normal-top-level() > -------- > > Again, this error _only_ occurs if find-image gets called before the > dump. Also, the error does not occur in -nw mode; it only appears > when run in X. > > I'd be happy to provide any clarification. Unfortunately, I'm not > familiar enough with Emacs' internals to provide a patch. > > -- > Bill Atkins > -- Bill Atkins ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: dump-emacs not compatible with toolbar-mode 2005-08-10 3:13 ` dump-emacs not compatible with toolbar-mode Bill Atkins 2005-08-10 3:18 ` Bill Atkins @ 2005-08-11 14:28 ` Richard M. Stallman 2005-08-12 17:51 ` Romain Francoise 1 sibling, 1 reply; 7+ messages in thread From: Richard M. Stallman @ 2005-08-11 14:28 UTC (permalink / raw) Cc: emacs-devel I fixed this. Thanks. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: dump-emacs not compatible with toolbar-mode 2005-08-11 14:28 ` Richard M. Stallman @ 2005-08-12 17:51 ` Romain Francoise 2005-08-13 14:40 ` Richard M. Stallman 0 siblings, 1 reply; 7+ messages in thread From: Romain Francoise @ 2005-08-12 17:51 UTC (permalink / raw) Cc: emacs-devel "Richard M. Stallman" <rms@gnu.org> writes: > I fixed this. Thanks. I'm assuming that your fix was this change: 2005-08-11 Richard M. Stallman <rms@gnu.org> * image.c (syms_of_image): Init image_types here, and call define_image_type. (init_image): Not here. It introduces a bug: now 'pbm and 'xbm aren't valid image types anymore: ELISP> (image-type-available-p 'pbm) nil ELISP> (image-type-available-p 'xbm) nil ELISP> Note that these two types are always supported in Emacs and you moved their initialization... This causes problems in Gnus because it relies on pbm being supported to display X-Faces. -- Romain Francoise <romain@orebokech.com> | I've become someone else's it's a miracle -- http://orebokech.com/ | nightmare... ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: dump-emacs not compatible with toolbar-mode 2005-08-12 17:51 ` Romain Francoise @ 2005-08-13 14:40 ` Richard M. Stallman 2005-08-14 10:11 ` Romain Francoise 0 siblings, 1 reply; 7+ messages in thread From: Richard M. Stallman @ 2005-08-13 14:40 UTC (permalink / raw) Cc: emacs-devel I fixed this. Thanks. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: dump-emacs not compatible with toolbar-mode 2005-08-13 14:40 ` Richard M. Stallman @ 2005-08-14 10:11 ` Romain Francoise 2005-08-14 21:04 ` Richard M. Stallman 0 siblings, 1 reply; 7+ messages in thread From: Romain Francoise @ 2005-08-14 10:11 UTC (permalink / raw) "Richard M. Stallman" <rms@gnu.org> writes: > I fixed this. Thanks. It looks like you didn't install the fix. -- Romain Francoise <romain@orebokech.com> | I used to think there is no it's a miracle -- http://orebokech.com/ | future left at all. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: dump-emacs not compatible with toolbar-mode 2005-08-14 10:11 ` Romain Francoise @ 2005-08-14 21:04 ` Richard M. Stallman 0 siblings, 0 replies; 7+ messages in thread From: Richard M. Stallman @ 2005-08-14 21:04 UTC (permalink / raw) Cc: emacs-devel It looks like you didn't install the fix. I often don't install changes immediately. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-08-14 21:04 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <66b7e34b050807121011b801fc@mail.gmail.com> [not found] ` <E1E2HyL-0006Sv-5A@fencepost.gnu.org> [not found] ` <66b7e34b05080821192d448e82@mail.gmail.com> [not found] ` <E1E2bvw-0003pS-BY@fencepost.gnu.org> 2005-08-10 3:13 ` dump-emacs not compatible with toolbar-mode Bill Atkins 2005-08-10 3:18 ` Bill Atkins 2005-08-11 14:28 ` Richard M. Stallman 2005-08-12 17:51 ` Romain Francoise 2005-08-13 14:40 ` Richard M. Stallman 2005-08-14 10:11 ` Romain Francoise 2005-08-14 21:04 ` Richard M. Stallman
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).