From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: "Richard M. Stallman" <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: emacs & MAXPATHLEN
Date: Fri, 29 Jul 2005 23:34:13 -0400
Message-ID: <E1Dyi73-0002Rx-0l@fencepost.gnu.org>
References: <87fytzj6a7.fsf@gmail.com> <E1DyITG-0007u6-7e@fencepost.gnu.org>
	<87pst2h35e.fsf@gmail.com> <u7jf967ku.fsf@gnu.org>
Reply-To: rms@gnu.org
NNTP-Posting-Host: main.gmane.org
X-Trace: sea.gmane.org 1122696107 9270 80.91.229.2 (30 Jul 2005 04:01:47 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sat, 30 Jul 2005 04:01:47 +0000 (UTC)
Cc: gscrivano@gmail.com, emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 30 06:01:40 2005
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1DyiXW-0007UU-Cx
	for ged-emacs-devel@m.gmane.org; Sat, 30 Jul 2005 06:01:34 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1Dyia3-0004ta-6c
	for ged-emacs-devel@m.gmane.org; Sat, 30 Jul 2005 00:04:11 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DyiZ1-0004UU-Rn
	for emacs-devel@gnu.org; Sat, 30 Jul 2005 00:03:08 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DyiYy-0004Re-Hy
	for emacs-devel@gnu.org; Sat, 30 Jul 2005 00:03:04 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DyiYw-0004Fy-V5
	for emacs-devel@gnu.org; Sat, 30 Jul 2005 00:03:03 -0400
Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1DyiJV-0007AA-MX
	for emacs-devel@gnu.org; Fri, 29 Jul 2005 23:47:05 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34)
	id 1Dyi73-0002Rx-0l; Fri, 29 Jul 2005 23:34:13 -0400
Original-To: Eli Zaretskii <eliz@gnu.org>
In-reply-to: <u7jf967ku.fsf@gnu.org> (message from Eli Zaretskii on Fri, 29
	Jul 2005 16:54:41 +0300)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:41328
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:41328

    > +      buf = malloc(strlen(pwd)+1);
    > +      if(!buf)
    > +        fatal ("`malloc' failed in init_buffer\n");

    This should have used xmalloc instead of calling malloc and checking
    for errors.

Actually I don't think so.  xmalloc reports errors using Fsignal, and
that is the wrong thing to do, this early in Emacs startup.

It might be ok just to use abort, since it should not be possible
to run out of memory at that point.

In xsmfns.c, it would be right to use xmalloc.