unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* reb-with-current-window
@ 2005-07-22  0:35 Juanma Barranquero
  2005-07-22 22:50 ` reb-with-current-window Richard M. Stallman
  0 siblings, 1 reply; 2+ messages in thread
From: Juanma Barranquero @ 2005-07-22  0:35 UTC (permalink / raw)


`reb-with-current-window' (from re-builder.el) is a poor man's
`with-selected-window', and I'd like to use the real thing.

So, options, in (my) preferred order:

 - Delete `reb-with-current-window' and use `with-selected-window'.
This is not as bad as it sounds, because I don't think the author is
maintaining re-builder outside Emacs. XEmacs also includes re-builder,
but they already have done changes to it that weren't merged back to
GNU Emacs. So no compatibility issue and no (much, if any) trouble
synch'ing versions.

 - Just redefine it conditionally:

  ; original definition, then:
  (when (fboundp 'with-selected-window)
    (fset 'reb-with-current-window 'with-selected-window))

 - Do something like

  (defalias 'reb-with-current-window
      (if (fboundp 'with-selected-window)
          'with-selected-window
        '(...)))

  Trouble is, the (...) is (macro lambda (...)), which is ugly.

 - Conditional:

  (if (fboundp 'with-selected-window)
      (defalias 'reb-with-current-window 'with-selected-window)
    (defmacro reb-with-current-window (...)

  but this makes the bytecompiler quite unhappy (or at least noisy).

 - Do nothing.

-- 
                    /L/e/k/t/u

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: reb-with-current-window
  2005-07-22  0:35 reb-with-current-window Juanma Barranquero
@ 2005-07-22 22:50 ` Richard M. Stallman
  0 siblings, 0 replies; 2+ messages in thread
From: Richard M. Stallman @ 2005-07-22 22:50 UTC (permalink / raw)
  Cc: emacs-devel

     - Delete `reb-with-current-window' and use `with-selected-window'.

That is the simplest and the best.
The others don't solve any problem important to us.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-07-22 22:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-22  0:35 reb-with-current-window Juanma Barranquero
2005-07-22 22:50 ` reb-with-current-window Richard M. Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).