From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: obsolete comment in tool-bar.el Date: Fri, 15 Jul 2005 14:10:48 -0400 Message-ID: References: <200507071915.j67JFZT29961@raven.dms.auburn.edu> <200507090235.j692ZER04883@raven.dms.auburn.edu> <200507110321.j6B3LgG09526@raven.dms.auburn.edu> <85y88dfcqw.fsf@lola.goethe.zz> <200507130302.j6D32qE05640@raven.dms.auburn.edu> <200507140208.j6E28tr08794@raven.dms.auburn.edu> <200507142205.j6EM51f12059@raven.dms.auburn.edu> <200507150324.j6F3OmC12530@raven.dms.auburn.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1121452690 16038 80.91.229.2 (15 Jul 2005 18:38:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 15 Jul 2005 18:38:10 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 15 20:38:09 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DtV3n-0001jZ-5q for ged-emacs-devel@m.gmane.org; Fri, 15 Jul 2005 20:37:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DtV5a-0005Ea-8O for ged-emacs-devel@m.gmane.org; Fri, 15 Jul 2005 14:39:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DtUwi-0008Pj-SE for emacs-devel@gnu.org; Fri, 15 Jul 2005 14:30:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DtUwe-0008NO-W0 for emacs-devel@gnu.org; Fri, 15 Jul 2005 14:29:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DtUwd-000897-5Y for emacs-devel@gnu.org; Fri, 15 Jul 2005 14:29:55 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DtUpj-0000JZ-6s for emacs-devel@gnu.org; Fri, 15 Jul 2005 14:22:47 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1DtUe8-0003Ce-Eq; Fri, 15 Jul 2005 14:10:48 -0400 Original-To: Luc Teirlinck In-reply-to: <200507150324.j6F3OmC12530@raven.dms.auburn.edu> (message from Luc Teirlinck on Thu, 14 Jul 2005 22:24:48 -0500 (CDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40944 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40944 More precisely, without my changes, if you specify an explicit :initialize keyword, the expansion of the define-minor-mode form contains two :initialize keywords, first ":initialize 'custom-initialize-default" and then, at some later place the explicit :initialize. That's not clean, and it might not be clear which one would "win". So it is better to keep your code, and pass just one :initialize. However, explicitly specified :set or :type keywords still expand to defcustoms with two :set or :type keywords. It would be cleaner to do the same thing for :set and :type--to suppress the default one when there is an explicit one.