From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Underlining in compile.el Date: Sat, 25 Jun 2005 12:40:32 -0400 Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1119718916 32044 80.91.229.2 (25 Jun 2005 17:01:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 25 Jun 2005 17:01:56 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 25 19:01:46 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DmE1n-0007Z4-6Z for ged-emacs-devel@m.gmane.org; Sat, 25 Jun 2005 19:01:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DmE93-000627-Te for ged-emacs-devel@m.gmane.org; Sat, 25 Jun 2005 13:08:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DmE4N-0004BA-Ie for emacs-devel@gnu.org; Sat, 25 Jun 2005 13:03:51 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DmE4C-00042R-MH for emacs-devel@gnu.org; Sat, 25 Jun 2005 13:03:41 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DmE4B-0003G9-NS for emacs-devel@gnu.org; Sat, 25 Jun 2005 13:03:39 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DmDmm-0005Bd-5t for emacs-devel@gnu.org; Sat, 25 Jun 2005 12:45:40 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1DmDho-0004GG-R4; Sat, 25 Jun 2005 12:40:32 -0400 Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:39505 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:39505 Does anyone want to write a cleaner implementation of the feature of underlining the link areas in compile.el? *** compile.el 12 Jun 2005 06:10:07 -0400 1.362 --- compile.el 16 Jun 2005 22:04:13 -0400 *************** *** 493,517 **** ;; backward-compatibility alias (put 'compilation-info-face 'face-alias 'compilation-info) (defvar compilation-message-face nil "Face name to use for whole messages. Faces `compilation-error-face', `compilation-warning-face', `compilation-info-face', `compilation-line-face' and `compilation-column-face' get prepended to this, when applicable.") ! (defvar compilation-error-face 'font-lock-warning-face "Face name to use for file name in error messages.") ! (defvar compilation-warning-face 'compilation-warning "Face name to use for file name in warning messages.") ! (defvar compilation-info-face 'compilation-info "Face name to use for file name in informational messages.") ! (defvar compilation-line-face 'font-lock-variable-name-face "Face name to use for line number in message.") ! (defvar compilation-column-face 'font-lock-type-face "Face name to use for column number in message.") ;; same faces as dired uses --- 493,552 ---- ;; backward-compatibility alias (put 'compilation-info-face 'face-alias 'compilation-info) + (defface compilation-error-file-name + '((default :inherit font-lock-warning-face) + (((supports :underline t)) :underline t)) + "Face for displaying file names in compilation errors." + :group 'font-lock-highlighting-faces + :version "22.1") + + (defface compilation-warning-file-name + '((default :inherit font-lock-warning-face) + (((supports :underline t)) :underline t)) + "Face for displaying file names in compilation errors." + :group 'font-lock-highlighting-faces + :version "22.1") + + (defface compilation-info-file-name + '((default :inherit compilation-info) + (((supports :underline t)) :underline t)) + "Face for displaying file names in compilation errors." + :group 'font-lock-highlighting-faces + :version "22.1") + + (defface compilation-line-number + '((default :inherit font-lock-variable-name-face) + (((supports :underline t)) :underline t)) + "Face for displaying file names in compilation errors." + :group 'font-lock-highlighting-faces + :version "22.1") + + (defface compilation-column-number + '((default :inherit font-lock-type-face) + (((supports :underline t)) :underline t)) + "Face for displaying file names in compilation errors." + :group 'font-lock-highlighting-faces + :version "22.1") + (defvar compilation-message-face nil "Face name to use for whole messages. Faces `compilation-error-face', `compilation-warning-face', `compilation-info-face', `compilation-line-face' and `compilation-column-face' get prepended to this, when applicable.") ! (defvar compilation-error-face 'compilation-error-file-name "Face name to use for file name in error messages.") ! (defvar compilation-warning-face 'compilation-warning-file-name "Face name to use for file name in warning messages.") ! (defvar compilation-info-face 'compilation-info-file-name "Face name to use for file name in informational messages.") ! (defvar compilation-line-face 'compilation-line-number "Face name to use for line number in message.") ! (defvar compilation-column-face 'compilation-column-number "Face name to use for column number in message.") ;; same faces as dired uses