From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: trivial bug of font-lock in Change Log mode. Date: Fri, 10 Jun 2005 11:25:23 +0900 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1118371190 24808 80.91.229.2 (10 Jun 2005 02:39:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 10 Jun 2005 02:39:50 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 10 04:39:49 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DgZQp-0006Pw-C5 for ged-emacs-devel@m.gmane.org; Fri, 10 Jun 2005 04:39:39 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DgZXr-0006Al-Mk for ged-emacs-devel@m.gmane.org; Thu, 09 Jun 2005 22:46:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DgZVs-00051T-Vm for emacs-devel@gnu.org; Thu, 09 Jun 2005 22:44:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DgZVq-0004z9-Aj for emacs-devel@gnu.org; Thu, 09 Jun 2005 22:44:50 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DgZVn-0004mJ-TY for emacs-devel@gnu.org; Thu, 09 Jun 2005 22:44:47 -0400 Original-Received: from [192.47.44.130] (helo=tsukuba.m17n.org) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1DgZDL-0000Bc-VY; Thu, 09 Jun 2005 22:25:44 -0400 Original-Received: from nfs.m17n.org (nfs.m17n.org [192.47.44.7]) by tsukuba.m17n.org (8.12.3/8.12.3/Debian-7.1) with ESMTP id j5A2PO86018247; Fri, 10 Jun 2005 11:25:24 +0900 Original-Received: from etlken (etlken.m17n.org [192.47.44.125]) by nfs.m17n.org (8.12.3/8.12.3/Debian-7.1) with ESMTP id j5A2POCq002526; Fri, 10 Jun 2005 11:25:24 +0900 Original-Received: from handa by etlken with local (Exim 3.36 #1 (Debian)) id 1DgZD1-0004He-00; Fri, 10 Jun 2005 11:25:23 +0900 Original-To: rms@gnu.org In-reply-to: (message from Richard Stallman on Sat, 28 May 2005 07:52:54 -0400) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/22.0.50 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:38488 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:38488 In article , Richard Stallman writes: > Anyway, I think this kind of discussion is useless unless we > know what kind of date format we are going to support. For > instance, the current one doesn't handle this kind of date > format (note "JST"): > Sat May 28 09:41:40 JST 2005 > The idea is to handle date formats that were actually used in change > logs, now or in the past. We don't want to aim to handle all date formats > that people use in other contexts. A user can use any kind of date formats in the context of ChangeLog file by customizing add-log-time-format. > I recall that we did previously use a different date format. > I don't remember what it was, but maybe you can find it from > old versions of add-log.el. Yes, that's something like this: Sat Jan 1 00:00:00 2000 If what you really mean is: "... handle the DEFAULT date formats that were actually used in Emacs ...", I'd like to install the attached patch. --- Kenichi Handa handa@m17n.org Index: add-log.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v retrieving revision 1.163 diff -c -r1.163 add-log.el *** add-log.el 29 May 2005 16:09:04 -0000 1.163 --- add-log.el 10 Jun 2005 02:20:26 -0000 *************** *** 216,223 **** (defvar change-log-font-lock-keywords '(;; ! ;; Date lines, new and old styles. ! ("^\\sw.........[0-9:+ ]*" (0 'change-log-date-face) ;; Name and e-mail; some people put e-mail in parens, not angles. ("\\([^<(]+?\\)[ \t]*[(<]\\([A-Za-z0-9_.+-]+@[A-Za-z0-9_.-]+\\)[>)]" nil nil --- 216,227 ---- (defvar change-log-font-lock-keywords '(;; ! ;; Date lines, new (2000-01-01) and old (Sat Jan 1 00:00:00 2000) styles. ! ;; Fixme: this regepx is just an approximate one and may match ! ;; wrongly with a non-date line existing as a random note. In ! ;; addition, using any kind of fixed setting like this doesn't ! ;; work if a user customizes add-log-time-format. ! ("^[0-9-]+ +\\|^\\(Sun\\|Mon\\|Tue\\|Wed\\|Thu\\|Fri\\|Sat\\) [A-z][a-z][a-z] [0-9:+ ]+" (0 'change-log-date-face) ;; Name and e-mail; some people put e-mail in parens, not angles. ("\\([^<(]+?\\)[ \t]*[(<]\\([A-Za-z0-9_.+-]+@[A-Za-z0-9_.-]+\\)[>)]" nil nil