From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: org-mode and mode hooks. Date: Sat, 28 May 2005 07:53:25 -0400 Message-ID: References: <87y8a3mnz8.fsf@xs4all.nl> <87ll63weye.fsf-monnier+emacs@gnu.org> <200505252135.j4PLZvt26969@raven.dms.auburn.edu> <87hdgrufcl.fsf-monnier+emacs@gnu.org> <200505260359.j4Q3xbj28809@raven.dms.auburn.edu> <87is16rsid.fsf-monnier+emacs@gnu.org> <200505261501.j4QF17h00246@raven.dms.auburn.edu> <87psveq60w.fsf-monnier+emacs@gnu.org> <200505271717.j4RHHGD07067@raven.dms.auburn.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1117281849 28256 80.91.229.2 (28 May 2005 12:04:09 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 28 May 2005 12:04:09 +0000 (UTC) Cc: mmaug@yahoo.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca, Lute.Kamstra.lists@xs4all.nl, dominik@science.uva.nl Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 28 14:04:00 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Dc02m-0002q5-JW for ged-emacs-devel@m.gmane.org; Sat, 28 May 2005 14:03:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dc07F-00068A-Gr for ged-emacs-devel@m.gmane.org; Sat, 28 May 2005 08:08:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dc00x-0002Qz-2C for emacs-devel@gnu.org; Sat, 28 May 2005 08:02:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dc00o-0002Oa-VS for emacs-devel@gnu.org; Sat, 28 May 2005 08:01:55 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dc00j-0002Ib-NO for emacs-devel@gnu.org; Sat, 28 May 2005 08:01:50 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dbzv2-0005Dt-LD for emacs-devel@gnu.org; Sat, 28 May 2005 07:55:56 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1Dbzsb-0004yY-TE; Sat, 28 May 2005 07:53:25 -0400 Original-To: Luc Teirlinck In-reply-to: <200505271717.j4RHHGD07067@raven.dms.auburn.edu> (message from Luc Teirlinck on Fri, 27 May 2005 12:17:16 -0500 (CDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37821 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37821 ! If the minor mode's set-up depends on the major mode, the function that ! does the initial set-up should record the value of the variable `major-mode' ! in the variable MODE-stored-mode. The reference "the function that does the initial set-up" is not concrete. I am not completely sure which function you mean. It would be better to refer to it by name. If this function is one that the user has to supply and define, then I ask: why make the user arrange to set MODE-stored-mode? Why not have define-global-minor-mode automatically arrange to save the value in that variable? Then maybe this variable would be something internal and it would not have to be mentioned in the doc string. Looking at your patch, it looks like this mechanism already is taken care of by code that is generated by define-global-minor-mode. So why did you mention this variable in the doc string? Just what is the user of define-global-minor-mode supposed to do? I cannot understand it.