From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: trivial bug of font-lock in Change Log mode. Date: Sat, 28 May 2005 09:48:47 +0900 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1117241415 18306 80.91.229.2 (28 May 2005 00:50:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 28 May 2005 00:50:15 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 28 02:50:04 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DbpWT-00044P-GM for ged-emacs-devel@m.gmane.org; Sat, 28 May 2005 02:49:53 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dbpaq-0000uH-NO for ged-emacs-devel@m.gmane.org; Fri, 27 May 2005 20:54:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DbpZF-0000YZ-5V for emacs-devel@gnu.org; Fri, 27 May 2005 20:52:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DbpZ1-0000OA-P4 for emacs-devel@gnu.org; Fri, 27 May 2005 20:52:36 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DbpYy-0000Iu-7j for emacs-devel@gnu.org; Fri, 27 May 2005 20:52:28 -0400 Original-Received: from [192.47.44.130] (helo=tsukuba.m17n.org) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1DbpWR-0004ij-8Y; Fri, 27 May 2005 20:49:51 -0400 Original-Received: from nfs.m17n.org (nfs.m17n.org [192.47.44.7]) by tsukuba.m17n.org (8.12.3/8.12.3/Debian-7.1) with ESMTP id j4S0mn86031032; Sat, 28 May 2005 09:48:49 +0900 Original-Received: from etlken (etlken.m17n.org [192.47.44.125]) by nfs.m17n.org (8.12.3/8.12.3/Debian-7.1) with ESMTP id j4S0mmCq000655; Sat, 28 May 2005 09:48:49 +0900 Original-Received: from handa by etlken with local (Exim 3.36 #1 (Debian)) id 1DbpVP-0002nK-00; Sat, 28 May 2005 09:48:47 +0900 Original-To: rms@gnu.org In-reply-to: (message from Richard Stallman on Fri, 27 May 2005 10:20:20 -0400) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/22.0.50 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37810 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37810 In article , Richard Stallman writes: >> ;; Date lines, new and old styles. >> ! ("^\\([1-9][0-9][0-9][0-9]-[0-9-]+\\|\\(Sun\\|Mon\\|Tue\\|Wed\\|Thu\\|Fri\\|Sat\\|Sun\\) \\sw\\sw\\sw\\)[0-9:+ ]*" >> (0 'change-log-date-face) >> Shouldn't that regexp end with + rather than *? > The original regexp also ended with '*', and I don't know > all the variations of date line. > It seems to me that it could not be a valid date > if that match is empty. Don't you think so? The regexp always matches with non-empty text even if the last is '*'. If we include the part "[0-9:+ ]*" in the second paren part, then I agree that the last should be '+' as this: "^\\([1-9][0-9][0-9][0-9]-[0-9-]+\\|\\(Sun\\|Mon\\|Tue\\|Wed\\|Thu\\|Fri\\|Sat\\|Sun\\) \\sw\\sw\\sw[0-9:+ ]+\\)" But, then, we don't need the top-level paren and we can use this: "^[1-9][0-9][0-9][0-9]-[0-9-]+\\|^\\(Sun\\|Mon\\|Tue\\|Wed\\|Thu\\|Fri\\|Sat\\|Sun\\) \\sw\\sw\\sw[0-9:+ ]+" Anyway, I think this kind of discussion is useless unless we know what kind of date format we are going to support. For instance, the current one doesn't handle this kind of date format (note "JST"): Sat May 28 09:41:40 JST 2005 I personally think that it's ok that we support only the current format; something like "2005-05-13". --- Kenichi Handa handa@m17n.org