From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: log-edit.el Date: Thu, 26 May 2005 02:01:02 -0400 Message-ID: References: <17044.23349.76511.530320@farnswood.snap.net.nz> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1117089024 32436 80.91.229.2 (26 May 2005 06:30:24 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 26 May 2005 06:30:24 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 26 08:30:23 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DbBsZ-0000Ee-0u for ged-emacs-devel@m.gmane.org; Thu, 26 May 2005 08:30:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DbBwZ-0002RY-Oy for ged-emacs-devel@m.gmane.org; Thu, 26 May 2005 02:34:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DbBfN-0004i4-Aq for emacs-devel@gnu.org; Thu, 26 May 2005 02:16:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DbBfE-0004gW-G6 for emacs-devel@gnu.org; Thu, 26 May 2005 02:16:23 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DbBfC-0004N1-AS for emacs-devel@gnu.org; Thu, 26 May 2005 02:16:14 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DbBRK-0002Fy-4F for emacs-devel@gnu.org; Thu, 26 May 2005 02:01:54 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1DbBQU-00049c-Dg; Thu, 26 May 2005 02:01:02 -0400 Original-To: Nick Roberts In-reply-to: <17044.23349.76511.530320@farnswood.snap.net.nz> (message from Nick Roberts on Wed, 25 May 2005 23:02:13 +1200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37677 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37677 (dolist (file files) ! ;; Prefix filename with a space to distinguish e.g fns.c xfns.c. ! (let* ((entries (log-edit-changelog-entries (concat " " file))) This change is clearly the wrong way to do it. The argument to log-edit-changelog-entries is supposed to be a file name. If it doesn't work, you should fix it, not enshrine the error by passing an arg that is not a file name. Also, I use log-edit-insert-changelog all the time but never use pcl-cvs. How about moving the node about log-edit from the pcl-cvs manual into the Emacs manual? Ok, please do. > No objection here, OK, I will merge the node "Editing a Log Message" from the pcl-cvs manual into the node "Features of the Log Entry Buffer" in the Emacs manual. When you propose to rearrange the manual, please wait for me to ok it. Please don't go ahead and do it just because a single other person says he likes the idea.