unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: acm@muc.de, emacs-devel@gnu.org
Subject: Re: Filling woes
Date: Sat, 21 May 2005 21:00:56 -0400	[thread overview]
Message-ID: <E1DZeps-00068U-5F@fencepost.gnu.org> (raw)
In-Reply-To: <85y8a94k0z.fsf@lola.goethe.zz> (message from David Kastrup on Sat, 21 May 2005 00:20:12 +0200)

    This is a very incompatible change, since adaptive-fill-function's
    return value previously carried no meaning.

Looking at the code, I think you're mistaken.  adaptive-fill-function
returns the string to use as the prefix, or nil.'

The change *is* incompatible, for a different reason.
It would cause adaptive-fill-function to be called in situations
where now it would not be called.  And adaptive-fill-function could
override matching adaptive-fill-regexp.

This can't break anything in Emacs because nothing in Emacs uses
adaptive-fill-function.  It could break some user Lisp code, though.
Pretest is when we are likely to find out about this; mostly users
would change their code.  So if we are going to make this change,
there's no harm doing it now.

However, it could be a good idea to first ask users who use
adaptive-fill-function to tell us how they use it, before deciding
whether to change anything here.

    While the current scheme appears braindead, we could make it somewhat
    saner in a compatible way by allowing adaptive-fill-regexp to be nil,
    in which case adaptive-fill-function would get called unconditionally.

That is how it works now.

  reply	other threads:[~2005-05-22  1:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-17 20:20 Filling woes Alan Mackenzie
2005-05-19  1:31 ` Stefan Monnier
2005-05-20 21:57 ` Richard Stallman
2005-05-20 22:20   ` David Kastrup
2005-05-22  1:00     ` Richard Stallman [this message]
2005-05-23 22:32   ` Alan Mackenzie
2005-05-28 19:03   ` Filling woes - documentation patch Alan Mackenzie
2005-05-29 12:04     ` Richard Stallman
2005-05-29 19:56       ` Filling woes - code, documentation and NEWS patches Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1DZeps-00068U-5F@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).