From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: details of flymake changes
Date: Thu, 21 Apr 2005 15:56:37 -0400
Message-ID: <E1DOhmv-00028e-OU@fencepost.gnu.org>
References: <20050421063459.79136.qmail@web54103.mail.yahoo.com>
	<87k6mwqkec.fsf@kali.intranet>
Reply-To: rms@gnu.org
NNTP-Posting-Host: main.gmane.org
X-Trace: sea.gmane.org 1114113580 12543 80.91.229.2 (21 Apr 2005 19:59:40 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Thu, 21 Apr 2005 19:59:40 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 21 21:59:36 2005
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1DOhpA-0003d2-2A
	for ged-emacs-devel@m.gmane.org; Thu, 21 Apr 2005 21:58:56 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1DOhtw-0006rX-5t
	for ged-emacs-devel@m.gmane.org; Thu, 21 Apr 2005 16:03:52 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DOhoG-0004nC-Oe
	for emacs-devel@gnu.org; Thu, 21 Apr 2005 15:58:00 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DOhoF-0004mG-9Z
	for emacs-devel@gnu.org; Thu, 21 Apr 2005 15:57:59 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DOhoE-0000fq-Oa
	for emacs-devel@gnu.org; Thu, 21 Apr 2005 15:57:58 -0400
Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1DOhpl-0004Zj-5s
	for emacs-devel@gnu.org; Thu, 21 Apr 2005 15:59:33 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34)
	id 1DOhmv-00028e-OU; Thu, 21 Apr 2005 15:56:37 -0400
Original-To: Marcelo Toledo <marcelo@marcelotoledo.org>
In-reply-to: <87k6mwqkec.fsf@kali.intranet> (message from Marcelo Toledo on
	Thu, 21 Apr 2005 11:22:51 -0300)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:36253
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36253

Looking thru flymake.el now, the only specific problems I recognized
were (1) doc string lines that are too long, and (2) arguments named
"...path" that refer to directory names or file names.

I am sure the problems were worse than that.  Perhaps if you have more
time to look thru the file you will spot other problems.

Oh, some lines are very deeply indented.  Reformatting that code code
make it clearer.  And the xemacs conditionals are done in a somewhat
ugly way.