From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: custom-set-minor-mode Date: Sun, 10 Apr 2005 12:48:34 -0400 Message-ID: References: <200504092207.j39M74D26179@raven.dms.auburn.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1113151761 16437 80.91.229.2 (10 Apr 2005 16:49:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 10 Apr 2005 16:49:21 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 10 18:49:19 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DKfcZ-0007rT-Cq for ged-emacs-devel@m.gmane.org; Sun, 10 Apr 2005 18:49:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DKfCV-00088P-UQ for ged-emacs-devel@m.gmane.org; Sun, 10 Apr 2005 12:22:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DKfB9-0007Ya-1j for emacs-devel@gnu.org; Sun, 10 Apr 2005 12:20:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DKfB1-0007Vd-Ig for emacs-devel@gnu.org; Sun, 10 Apr 2005 12:20:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DKfB1-0007Ug-15 for emacs-devel@gnu.org; Sun, 10 Apr 2005 12:20:47 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DKfdt-00083k-Rq for emacs-devel@gnu.org; Sun, 10 Apr 2005 12:50:37 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1DKfbu-00011x-G3; Sun, 10 Apr 2005 12:48:34 -0400 Original-To: Luc Teirlinck In-reply-to: <200504092207.j39M74D26179@raven.dms.auburn.edu> (message from Luc Teirlinck on Sat, 9 Apr 2005 17:07:04 -0500 (CDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:35838 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35838 Otherwise Custom might get confused if something "simplifies" the non-nil value to `t', as I believe `define-minor-mode' does. On the other hand, it is clearly documented that any non-nil value of the variable indicates an enabled mode. Yes, any non-nil value *in the variable* should enable the mode. So your change is clearly correct. However, 0 as argument to the minor mode function is supposed to turn the mode off. Could you verify that still works right afetr your change? If it doesn't, another change in another place is probably needed.