unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* custom and defalias
@ 2005-02-20  1:21 Luc Teirlinck
  2005-02-21 10:21 ` Richard Stallman
  0 siblings, 1 reply; 2+ messages in thread
From: Luc Teirlinck @ 2005-02-20  1:21 UTC (permalink / raw)


I relatively recently committed the patch below to custom.el.  What
the patch did was make Custom recognize aliases.  For instance, the
option `blink-cursor' was recently declared obsolete and made into an
alias for `blink-cursor-mode'.  Without the patch, if blink-cursor was
set in the `custom-set-variables' form, it would no longer get recognized.
After the patch it is recognized.  But then Custom updates the
obsolete `blink-cursor' with `blink-cursor-mode', which would be
ideal, except that if one then uses the same custom-set-variables form
in Emacs 21.3, it does not work any more.

I do not know what to do with this.

Here is the patch.  To avoid confusion, it was _already_ installed a
little while ago.

===File ~/custom.el-diff====================================
*** custom.el	10 Feb 2005 09:52:54 -0600	1.79
--- custom.el	10 Feb 2005 20:04:47 -0600	
***************
*** 777,783 ****
      (while args
        (let ((entry (car args)))
  	(if (listp entry)
! 	    (let* ((symbol (nth 0 entry))
  		   (value (nth 1 entry))
  		   (now (nth 2 entry))
  		   (requests (nth 3 entry))
--- 777,783 ----
      (while args
        (let ((entry (car args)))
  	(if (listp entry)
! 	    (let* ((symbol (indirect-variable (nth 0 entry)))
  		   (value (nth 1 entry))
  		   (now (nth 2 entry))
  		   (requests (nth 3 entry))
***************
*** 809,815 ****
  	  (message "Warning: old format `custom-set-variables'")
  	  (ding)
  	  (sit-for 2)
! 	  (let ((symbol (nth 0 args))
  		(value (nth 1 args)))
  	    (put symbol 'saved-value (list value))
              (custom-push-theme 'theme-value symbol theme 'set value))
--- 809,815 ----
  	  (message "Warning: old format `custom-set-variables'")
  	  (ding)
  	  (sit-for 2)
! 	  (let ((symbol (indirect-variable (nth 0 args)))
  		(value (nth 1 args)))
  	    (put symbol 'saved-value (list value))
              (custom-push-theme 'theme-value symbol theme 'set value))
============================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: custom and defalias
  2005-02-20  1:21 custom and defalias Luc Teirlinck
@ 2005-02-21 10:21 ` Richard Stallman
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Stallman @ 2005-02-21 10:21 UTC (permalink / raw)
  Cc: emacs-devel

    I relatively recently committed the patch below to custom.el.  What
    the patch did was make Custom recognize aliases.  For instance, the
    option `blink-cursor' was recently declared obsolete and made into an
    alias for `blink-cursor-mode'.  Without the patch, if blink-cursor was
    set in the `custom-set-variables' form, it would no longer get recognized.
    After the patch it is recognized.  But then Custom updates the
    obsolete `blink-cursor' with `blink-cursor-mode', which would be
    ideal, except that if one then uses the same custom-set-variables form
    in Emacs 21.3, it does not work any more.

    I do not know what to do with this.

Unless someone has an idea for a change that is clearly desirable,
we should just live with it.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-02-21 10:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-20  1:21 custom and defalias Luc Teirlinck
2005-02-21 10:21 ` Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).