* Re: proofreading man/dired.texi
2005-02-16 1:51 ` Miles Bader
@ 2005-02-16 4:46 ` Stefan Monnier
2005-02-17 10:35 ` Richard Stallman
2005-02-17 14:29 ` Matt Hodges
2 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2005-02-16 4:46 UTC (permalink / raw)
Cc: emacs-devel, rms, Joakim Verona, miles
> (1) The function name "wdired-change-to-wdired-mode" is bizarre; why
> not just `wdired-mode'???? Is there another way one is supposed to
> enter it?
If it behaved like a minor mode, that would make sense. But it behaves more
like a major mode right now, so it makes sense to have a separate command
which does the pre-processing needed before entering the wdired-mode
major mode. In any case, it's probably more accidental than anything else.
> (2) One must hit `C-c C-c' for changes to take effect; this seems a
> bit heavy-weight -- why not just RET (which seems to be what other
> systems use)?
I don't know of any other system that allows you to do what wdired does.
Most others I know are more like dired-efap: they allow you to edit just one
file name.
> (3) Similarly, in analogy to other systems, it might be nice if there
> was some obvious visual indication that wdired was active and
> filenames "open for editting" -- e.g., if the filenames looked like a
> customize-style "input field" (one might even use the same abstract
> face for both, e.g. define an `input-field' face, and have customize
> inherit from it).
Similarly, other systems only provide "one field at a time". But since
wdired only handles modifications in some fields and not in others, it might
indeed make sense to "highlight" the parts that can be changed. Maybe with
an `input-field' face.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: proofreading man/dired.texi
2005-02-16 1:51 ` Miles Bader
2005-02-16 4:46 ` Stefan Monnier
@ 2005-02-17 10:35 ` Richard Stallman
2005-02-17 14:29 ` Matt Hodges
2 siblings, 0 replies; 6+ messages in thread
From: Richard Stallman @ 2005-02-17 10:35 UTC (permalink / raw)
Cc: monnier, joakim, emacs-devel
BTW, I noticed that wdired seems to be a bit unintuitive:
(1) The function name "wdired-change-to-wdired-mode" is bizarre; why
not just `wdired-mode'???? Is there another way one is supposed to
enter it?
(2) One must hit `C-c C-c' for changes to take effect; this seems a
bit heavy-weight -- why not just RET (which seems to be what other
systems use)?
(3) Similarly, in analogy to other systems, it might be nice if there
was some obvious visual indication that wdired was active and
filenames "open for editting" -- e.g., if the filenames looked like a
customize-style "input field" (one might even use the same abstract
face for both, e.g. define an `input-field' face, and have customize
inherit from it).
Thoughts?
They all seem like good ideas--I think you should change them.
But it would be good to talk with the wdired maintainer first.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: proofreading man/dired.texi
2005-02-16 1:51 ` Miles Bader
2005-02-16 4:46 ` Stefan Monnier
2005-02-17 10:35 ` Richard Stallman
@ 2005-02-17 14:29 ` Matt Hodges
2 siblings, 0 replies; 6+ messages in thread
From: Matt Hodges @ 2005-02-17 14:29 UTC (permalink / raw)
>>>>> Miles Bader writes:
> (2) One must hit `C-c C-c' for changes to take effect; this seems a
> bit heavy-weight -- why not just RET (which seems to be what other
> systems use)?
I agree that this makes sense if you want to edit one filename at a
time, and then commit this change immediately. However, if you edit
multiple filenames using, e.g., replace-string, replace-regexp,
string-rectangle (or whatever), then I think it's reasonable to have
something like C-c C-c to commit these changes.
> (3) Similarly, in analogy to other systems, it might be nice if
> there was some obvious visual indication that wdired was active and
> filenames "open for editting" -- e.g., if the filenames looked like
> a customize-style "input field" (one might even use the same
> abstract face for both, e.g. define an `input-field' face, and have
> customize inherit from it).
I think it would be useful to have some visual cue for filenames that
have been changed but not committed. Even more so if it becomes
possible to commit changes for single filenames (with RET) without
exiting wdired-mode.
Matt
^ permalink raw reply [flat|nested] 6+ messages in thread