unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: New undo element (fun . args)
Date: Thu, 03 Feb 2005 14:13:28 -0500	[thread overview]
Message-ID: <E1CwmPw-00035j-MS@fencepost.gnu.org> (raw)
In-Reply-To: <m3brb3nf5a.fsf@kfs-l.imdomain.dk> (no-spam@cua.dk)

      /* Make sure this produces at least one undo entry,
	 so the test in `undo' for continuing an undo series
	 will work right.  */
      if (EQ (oldlist, current_buffer->undo_list))
	current_buffer->undo_list
	  = Fcons (list3 (Qapply, Qcdr, nil), current_buffer->undo_list);


    I don't understand why this is necessary.  The primitive-undo
    continues to the next undo boundary, so why is it important what is
    recorded "between undo boundaries" ?

I think it is necessary for this code to work:

		     ;; If something (a timer or filter?) changed the buffer
		     ;; since the previous command, don't continue the undo seq.
		     (let ((list buffer-undo-list))
		       (while (eq (car list) nil)
			 (setq list (cdr list)))
		       ;; If the last undo record made was made by undo
		       ;; it shows nothing else happened in between.
		       (gethash list undo-equiv-table))))

If undoing does not generate any undo entries, there will be nothing
for this hash mark to ride on.  However, I may have misunderstood
something.

      It works
    to some extent, but as soon as undo hits one of the entries I added to
    the undo list, it gets stuck -- and the pending undo list seems to
    be stuck at that specific (apply cdr ...) entry.

Could you debug precisely what is happening when it is "stuck" as you
say?  In what way does the undo process fail to work?  Where is the bug?

  reply	other threads:[~2005-02-03 19:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-30  0:47 New undo element (fun . args) Kim F. Storm
2005-01-30  1:24 ` Miles Bader
2005-01-30 15:07   ` Stefan Monnier
2005-01-30 17:22     ` Kim F. Storm
2005-01-30 18:11     ` Kim F. Storm
2005-01-31 12:01     ` Richard Stallman
2005-01-31 13:02       ` Kim F. Storm
2005-01-31 22:53         ` Kim F. Storm
2005-02-02  7:28           ` Richard Stallman
2005-02-02  7:28         ` Richard Stallman
2005-02-02 14:35           ` Stefan Monnier
2005-02-02 15:41             ` Kim F. Storm
2005-02-03 19:13               ` Richard Stallman [this message]
2005-02-04 15:40                 ` Kim F. Storm
2005-02-05 17:39                   ` Richard Stallman
2005-02-07  8:23                     ` Kim F. Storm
2005-02-07 20:51                       ` Richard Stallman
2005-02-09 21:50                         ` Kim F. Storm
2005-02-07 11:51                   ` Kim F. Storm
2005-02-07 12:25                     ` David Kastrup
2005-02-07 14:14                       ` Stefan Monnier
2005-02-08 11:47                       ` Richard Stallman
2005-02-08 11:46                     ` Richard Stallman
2005-02-08 12:53                       ` Kim F. Storm
2005-02-03 19:13             ` Richard Stallman
2005-01-31  0:19 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1CwmPw-00035j-MS@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).