Patch to

Patch to

[Francis Litterio]

The below patch enables adaptive-fill-mode to properly fill paragraphs
that use 'o' as a bullet, like this:

  o  Testing one two three one two three one two three one two three one
     two three one two three one two three.

I hope this is considered useful.
--
Francis Litterio
franl <at> world . std . com


--- fill.el	20 Jul 2004 16:51:13 -0400	1.173
+++ fill.el	27 Jan 2005 13:45:06 -0500	
@@ -87,7 +87,7 @@
 (defcustom adaptive-fill-regexp
   ;; Added `!' for doxygen comments starting with `//!' or `/*!'.
   ;; Added `%' for TeX comments.
-  (purecopy "[ \t]*\\([-!|#%;>*]+[ \t]*\\|(?[0-9]+[.)][ \t]*\\)*")
+  (purecopy "[ \t]*\\([-!|#%;>*o]+[ \t]*\\|(?[0-9]+[.)][ \t]*\\)*")
   "*Regexp to match text at start of line that constitutes indentation.
 If Adaptive Fill mode is enabled, a prefix matching this pattern
 on the first and second lines of a paragraph is used as the

Re: Patch to

[Richard Stallman]

    The below patch enables adaptive-fill-mode to properly fill paragraphs
    that use 'o' as a bullet, like this:

      o  Testing one two three one two three one two three one two three one
	 two three one two three one two three.

That result is an improvement, but I wonder if this might also
lead to false identification of prefixes in some cases.
I can't see, off hand, how that could happen, I just have
a concern about it.  Does anyone else see such cases?

If not, we can try it and see if it causes any problems.

Re: Patch to

[Stefan Monnier]

> That result is an improvement, but I wonder if this might also
> lead to false identification of prefixes in some cases.
> I can't see, off hand, how that could happen, I just have
> a concern about it.  Does anyone else see such cases?

In Spanish, "o" means "or".


        Stefan

Re: Patch to

[Francis Litterio]

Richard Stallman wrote:

>     The below patch enables adaptive-fill-mode to properly fill paragraphs
>     that use 'o' as a bullet, like this:
>
>       o  Testing one two three one two three one two three one two three one
> 	 two three one two three one two three.
>
> That result is an improvement, but I wonder if this might also
> lead to false identification of prefixes in some cases.
> I can't see, off hand, how that could happen, I just have
> a concern about it.  Does anyone else see such cases?
>
> If not, we can try it and see if it causes any problems.

I've found one case already where it causes a problem -- when filling a
long line that starts with a word beginning with 'o' or 'O', you end up
with a paragraph looking like this:

Of course, this is just a long line to demonstrate the problem.  Blah
 blah blah blah blah blah blah blah blah blah blah blah blah blah blah
 blah blah blah blah blah.

I think the regexp can be adjusted to compensate for this, but Stefan
Monnier's objection about "o" meaning "or" in Spanish is a much more
significant problem, and probably reason to leave this patch out.

Sorry for any confusion.
--
Francis Litterio
franl <at> world . std . com