[jari.aalto@cante.net: [patch] 21.3 find-dired.el - Add 'g' key to repeat last find command]

[jari.aalto@cante.net: [patch] 21.3 find-dired.el - Add 'g' key to repeat last find command]

[Richard Stallman]

Providing proper support for g is more filling a gap
than adding a feature, so would someone please install this and ack?

------- Start of forwarded message -------
From: jari.aalto@cante.net (Jari+mail.emacs)
To: bug-gnu-emacs@gnu.org
Date: Fri, 21 Jan 2005 10:02:42 +0200
Subject: [patch] 21.3 find-dired.el - Add 'g' key to repeat last find command
Sender: bug-gnu-emacs-bounces+rms=gnu.org@gnu.org
X-Spam-Status: No, hits=-0.5 required=5.0
	tests=PATCH_UNIFIED_DIFF,RCVD_IN_ORBS,USER_AGENT_GNUS_UA
	version=2.55
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)


As with dired 'g', the results of find-dired can now be repeated. With log
files and IMAP mail directories, this feature is quite useful.

2005-01-21 Fri  Jari  <jari dot aalto A T cante dot net>

        * find-dired.el (find-dired-revert): New function.
        (find-dir): New variable.
        (find-dired): Added local `revert-buffer-function' and
        restored key 'g' to rerun last find command.


- --- find-dired.el	2005-01-21 09:33:59+02	1.1
+++ find-dired.el	2005-01-21 09:56:04+02	1.2
@@ -69,9 +69,23 @@
 (defvar find-args nil
   "Last arguments given to `find' by \\[find-dired].")
 
+(defvar find-dir nil
+  "Last arguments given to `find' by \\[find-dired].")
+
 ;; History of find-args values entered in the minibuffer.
 (defvar find-args-history nil)
 
+(defun find-dired-revert (&optional ignore-auto noconfirm)
+  "Rerun last command `find-dired' command.
+Optional arguments IGNORE-AUTO and NOCONFIRM are not used."
+  (interactive)
+  (let* ((args find-args)
+         (dir  find-dir))
+    (if (and dir args)
+        (find-dired dir args)
+      (message
+       "Find dired: no previous information stored to repeat find."))))
+
 ;;;###autoload
 (defun find-dired (dir args)
   "Run `find' and go into Dired mode on a buffer of the output.
@@ -92,6 +106,7 @@
     ;; Check that it's really a directory.
     (or (file-directory-p dir)
 	(error "find-dired needs a directory: %s" dir))
+    (setq find-dir dir)  ; Save for later use
     (switch-to-buffer (get-buffer-create "*Find*"))
 
     ;; See if there's still a `find' running, and offer to kill
@@ -124,7 +139,8 @@
     ;; This really should rerun the find command, but I don't
     ;; have time for that.
     (use-local-map (append (make-sparse-keymap) (current-local-map)))
- -    (define-key (current-local-map) "g" 'undefined)
+    ;; (define-key (current-local-map) "g" 'undefined)
+    (set (make-local-variable 'revert-buffer-function) 'find-dired-revert)
     ;; Set subdir-alist so that Tree Dired will work:
     (if (fboundp 'dired-simple-subdir-alist)
 	;; will work even with nested dired format (dired-nstd.el,v 1.15



_______________________________________________
Bug-gnu-emacs mailing list
Bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
------- End of forwarded message -------

Re: [jari.aalto@cante.net: [patch] 21.3 find-dired.el - Add 'g' key to repeat last find command]

[Luc Teirlinck]

Richard Stallman wrote:

   Providing proper support for g is more filling a gap
   than adding a feature, so would someone please install this and ack?

What is "improper" about the current support for `g' in find-dired?

I have the impression that the OP is not using CVS Emacs.

Please do not install this change blindly.

Sincerely,

Luc.

Re: Re: Re: [jari.aalto@cante.net: [patch] 21.3 find-dired.el - Add 'g' key to repeat last find command] SPF_HELO_PASS autolearn=ham version=3.0.2

[Jari Aalto]

| 
| Richard Stallman wrote:
| 
|    Providing proper support for g is more filling a gap
|    than adding a feature, so would someone please install this and ack?
| 
| What is "improper" about the current support for `g' in find-dired?
| 
| I have the impression that the OP is not using CVS Emacs.

I do not use Emacs CVS, so if this has been implemented already, that's good.

Jari

Re: [jari.aalto@cante.net: [patch] 21.3 find-dired.el - Add 'g' key to repeat last find command]

[Richard Stallman]

       Providing proper support for g is more filling a gap
       than adding a feature, so would someone please install this and ack?

    What is "improper" about the current support for `g' in find-dired?

I didn't know this had been implemented.  If the job is already done,
that's fine with me.