From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Message buffer time-stamps Date: Sat, 25 Dec 2004 10:13:57 -0500 Message-ID: References: <87sm5wtpwa.fsf@jurta.org> Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1103988109 710 80.91.229.6 (25 Dec 2004 15:21:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 25 Dec 2004 15:21:49 +0000 (UTC) Cc: yonirabkin@gmail.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 25 16:21:43 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CiDjj-000669-00 for ; Sat, 25 Dec 2004 16:21:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CiDuQ-0001ML-Tc for ged-emacs-devel@m.gmane.org; Sat, 25 Dec 2004 10:32:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CiDtT-0000xa-Ih for emacs-devel@gnu.org; Sat, 25 Dec 2004 10:31:47 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CiDtN-0000r8-AY for emacs-devel@gnu.org; Sat, 25 Dec 2004 10:31:41 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CiDtM-0000r5-U2 for emacs-devel@gnu.org; Sat, 25 Dec 2004 10:31:41 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CiDhT-0005Oj-5M for emacs-devel@gnu.org; Sat, 25 Dec 2004 10:19:23 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1CiDcD-0004xI-97; Sat, 25 Dec 2004 10:13:57 -0500 Original-To: Juri Linkov In-reply-to: <87sm5wtpwa.fsf@jurta.org> (message from Juri Linkov on Fri, 24 Dec 2004 03:02:14 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31387 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31387 I propose the patch that calls after-change-functions after *Messages* buffer modification, i.e. when new messages are added to the *Messages* buffer by the `message' function. That is not safe. Messages are output from lots of places, and I don't know if all of them can handle GC. This patch would cause GCs in those places. You could make this safe by checking every call to the `message_' functions and verifying that GC is safe in each of them. However, I'd suggest instead using an idle timer to check that a message has been added, and to add a timestamp. There is another issue. Right now there's a feature to combine repeated messages. If you put time stamps in the buffer, that would break this feature, unless the time stamp code takes pains to keep it working.