unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: yonirabkin@gmail.com, emacs-devel@gnu.org
Subject: Re: Message buffer time-stamps
Date: Sat, 25 Dec 2004 10:13:57 -0500	[thread overview]
Message-ID: <E1CiDcD-0004xI-97@fencepost.gnu.org> (raw)
In-Reply-To: <87sm5wtpwa.fsf@jurta.org> (message from Juri Linkov on Fri, 24 Dec 2004 03:02:14 +0200)

    I propose the patch that calls after-change-functions after *Messages*
    buffer modification, i.e. when new messages are added to the
    *Messages* buffer by the `message' function.

That is not safe.  Messages are output from lots of places, and I
don't know if all of them can handle GC.  This patch would cause GCs
in those places.

You could make this safe by checking every call to the `message_'
functions and verifying that GC is safe in each of them.

However, I'd suggest instead using an idle timer to check that a message
has been added, and to add a timestamp.

There is another issue.  Right now there's a feature to combine
repeated messages.  If you put time stamps in the buffer, that would
break this feature, unless the time stamp code takes pains to keep
it working.

  reply	other threads:[~2004-12-25 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-23  9:01 Message buffer time-stamps Yoni Rabkin
2004-12-24  1:02 ` Juri Linkov
2004-12-25 15:13   ` Richard Stallman [this message]
2004-12-26  2:47     ` Juri Linkov
2004-12-27  4:09       ` Richard Stallman
2004-12-29  7:07         ` Juri Linkov
2004-12-29 17:54           ` Juri Linkov
2004-12-30 16:43           ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1CiDcD-0004xI-97@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=yonirabkin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).