* [patch] mode-line faces on 256-color terminals
@ 2004-12-22 23:08 Dan Nicolaescu
2004-12-23 4:40 ` Eli Zaretskii
2004-12-23 19:32 ` Richard Stallman
0 siblings, 2 replies; 6+ messages in thread
From: Dan Nicolaescu @ 2004-12-22 23:08 UTC (permalink / raw)
The mode-line* faces were somehow missed when converting the face
definitions in faces.el to use min-colors, so that they work on
terminals that support 88 (or 256) colors.
This patch fixes the above issue. Is it OK?
2004-12-22 Dan Nicolaescu <dann@ics.uci.edu>
* faces.el (mode-line, mode-line-inactive): Use min-colors.
Index: faces.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v
retrieving revision 1.296
diff -c -3 -p -c -r1.296 faces.el
*** faces.el 21 Dec 2004 11:37:25 -0000 1.296
--- faces.el 22 Dec 2004 23:02:48 -0000
*************** created."
*** 1783,1789 ****
(defface mode-line
! '((((type x w32 mac) (class color))
:box (:line-width -1 :style released-button)
:background "grey75" :foreground "black")
(t
--- 1783,1789 ----
(defface mode-line
! '((((class color) (min-colors 88))
:box (:line-width -1 :style released-button)
:background "grey75" :foreground "black")
(t
*************** created."
*** 1796,1806 ****
(defface mode-line-inactive
'((default
:inherit mode-line)
! (((type x w32 mac) (background light) (class color))
:weight light
:box (:line-width -1 :color "grey75" :style nil)
:foreground "grey20" :background "grey90")
! (((type x w32 mac) (background dark) (class color))
:weight light
:box (:line-width -1 :color "grey40" :style nil)
:foreground "grey80" :background "grey30"))
--- 1796,1806 ----
(defface mode-line-inactive
'((default
:inherit mode-line)
! (((class color) (min-colors 88) (background light))
:weight light
:box (:line-width -1 :color "grey75" :style nil)
:foreground "grey20" :background "grey90")
! (((class color) (min-colors 88) (background dark) )
:weight light
:box (:line-width -1 :color "grey40" :style nil)
:foreground "grey80" :background "grey30"))
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] mode-line faces on 256-color terminals
2004-12-22 23:08 [patch] mode-line faces on 256-color terminals Dan Nicolaescu
@ 2004-12-23 4:40 ` Eli Zaretskii
2004-12-23 18:44 ` Dan Nicolaescu
2004-12-23 19:32 ` Richard Stallman
1 sibling, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2004-12-23 4:40 UTC (permalink / raw)
Cc: emacs-devel
> From: Dan Nicolaescu <dann@godzilla.ics.uci.edu>
> Date: Wed, 22 Dec 2004 15:08:50 -0800
>
> The mode-line* faces were somehow missed when converting the face
> definitions in faces.el to use min-colors, so that they work on
> terminals that support 88 (or 256) colors.
>
> This patch fixes the above issue. Is it OK?
It's okay, provided that you checked that this:
> (defface mode-line
> ! '((((class color) (min-colors 88))
> :box (:line-width -1 :style released-button)
> :background "grey75" :foreground "black")
doesn't cause any trouble on a tty because of the :box and
released-button features it uses.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] mode-line faces on 256-color terminals
2004-12-23 4:40 ` Eli Zaretskii
@ 2004-12-23 18:44 ` Dan Nicolaescu
0 siblings, 0 replies; 6+ messages in thread
From: Dan Nicolaescu @ 2004-12-23 18:44 UTC (permalink / raw)
Cc: emacs-devel
"Eli Zaretskii" <eliz@gnu.org> writes:
> It's okay, provided that you checked that this:
>
> > (defface mode-line
> > ! '((((class color) (min-colors 88))
> > :box (:line-width -1 :style released-button)
> > :background "grey75" :foreground "black")
>
> doesn't cause any trouble on a tty because of the :box and
> released-button features it uses.
Thanks. I tested it and it works fine. Committed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] mode-line faces on 256-color terminals
2004-12-22 23:08 [patch] mode-line faces on 256-color terminals Dan Nicolaescu
2004-12-23 4:40 ` Eli Zaretskii
@ 2004-12-23 19:32 ` Richard Stallman
2004-12-23 19:46 ` Dan Nicolaescu
1 sibling, 1 reply; 6+ messages in thread
From: Richard Stallman @ 2004-12-23 19:32 UTC (permalink / raw)
Cc: emacs-devel
Could you wait a week for the people who know the most about
face issues to comment? If there has been no criticism in a week,
please install it, or else ask me to install it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] mode-line faces on 256-color terminals
2004-12-23 19:32 ` Richard Stallman
@ 2004-12-23 19:46 ` Dan Nicolaescu
2004-12-24 14:33 ` Richard Stallman
0 siblings, 1 reply; 6+ messages in thread
From: Dan Nicolaescu @ 2004-12-23 19:46 UTC (permalink / raw)
Cc: emacs-devel
Richard Stallman <rms@gnu.org> writes:
> Could you wait a week for the people who know the most about
> face issues to comment? If there has been no criticism in a week,
> please install it, or else ask me to install it.
Oops, I have already installed it based on Eli's OK.
What should I do, should I revert the patch now?
Note that the patch only affects the face definitions for mode-line
and mode-line-inactive when running on terminals that support more
than 88 colors, nothing else should be affected.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] mode-line faces on 256-color terminals
2004-12-23 19:46 ` Dan Nicolaescu
@ 2004-12-24 14:33 ` Richard Stallman
0 siblings, 0 replies; 6+ messages in thread
From: Richard Stallman @ 2004-12-24 14:33 UTC (permalink / raw)
Cc: emacs-devel
> Could you wait a week for the people who know the most about
> face issues to comment? If there has been no criticism in a week,
> please install it, or else ask me to install it.
Oops, I have already installed it based on Eli's OK.
What should I do, should I revert the patch now?
I think he is one of the people who ought to know.
Since he thinks it is ok, probably it is.
So you may as well leave it installed now.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-12-24 14:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-22 23:08 [patch] mode-line faces on 256-color terminals Dan Nicolaescu
2004-12-23 4:40 ` Eli Zaretskii
2004-12-23 18:44 ` Dan Nicolaescu
2004-12-23 19:32 ` Richard Stallman
2004-12-23 19:46 ` Dan Nicolaescu
2004-12-24 14:33 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).