unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Subject: Re: Changes in the arg list for custom-set-variables - how should it be handled
Date: Tue, 21 Dec 2004 06:21:51 -0500	[thread overview]
Message-ID: <E1Cgi5P-0007Zc-Kf@fencepost.gnu.org> (raw)
In-Reply-To: <007c01c4da6a$ae922b60$0200a8c0@sedrcw11488> (lennart.borgman.073@student.lu.se)

I sent this message a few weeks ago, but nobody spoke up
to work on this.  Who would like to do this change?

    I have seen that there are some changes in the arg list for
    custom-set-variables from the current Emacs to CVS Emacs. For example for
    global-font-lock-mode:

	'(global-font-lock-mode t nil (font-lock))

    should be changed too

	'(global-font-lock-mode t nil (font-core))

Stephan Stahl <stahl@eos.franken.de> pointed out that the user does
not need to make this change, but that the new form, when written by
Emacs, could make the init file fail to load in older Emacs versions.

This kind of thing occurs when :require is used in the defcustom
macro.  In this case it results from the following code in
define-minor-mode:

	       ,@(cond
		  ((not (and curfile require)) nil)
		  ((not (eq require t)) `(:require ,require))
		  (t `(:require
		       ',(intern (file-name-nondirectory
				  (file-name-sans-extension curfile))))))

This puts a :require into the defcustom generated for the minor mode.
The result is that loading the setting of the variable forces loading
of the file the variable is defined in.  I suppose the reason for this
is so that the :set function can work right, but in the case
of global-font-lock-mode it is unnecessary since font-core.el is
preloaded.

In cases where such a definition is autoloaded instead, autoload.el
could set up something to record the necessary information elsewhere,
so that setting the variable will load the right files.  That way, it
won't have to be recorded in the custom-set-variables call, and this
problem will not happen.

Would someone like to work on this?  Please respond if you want
to do it.

  parent reply	other threads:[~2004-12-21 11:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-05  1:35 Changes in the arg list for custom-set-variables - how should it be handled Lennart Borgman
2004-12-05 11:19 ` Changes in the arg list for custom-set-variables - how should it behandled Stephan Stahl
2004-12-07  4:24 ` Changes in the arg list for custom-set-variables - how should it be handled Richard Stallman
2004-12-21 11:21 ` Richard Stallman [this message]
2005-01-05  3:31 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1Cgi5P-0007Zc-Kf@fencepost.gnu.org \
    --to=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).