unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: isearch highlighting
Date: Mon, 13 Dec 2004 14:51:28 -0500	[thread overview]
Message-ID: <E1CdwEC-0005Rk-MR@fencepost.gnu.org> (raw)
In-Reply-To: <87fz2e6h6b.fsf@jurta.org> (message from Juri Linkov on Fri, 10 Dec 2004 04:06:04 +0200)

    1. When Emacs hangs while searching with isearch for a regexp with
    nested repetitions, it can be interrupted with C-g.  Fine.  But when
    it hangs while highlighting other occurrences of the search string with
    isearch-lazy-highlight invoked by a timer, it can't be interrupted.
    I think it is safe to put the body of `isearch-lazy-highlight-update'
    in the `with-local-quit' block, because quit in this function can't
    lead to a corrupted state.

I just installed the code for while-no-input.  I think you should
use that.

    C-x RET C-\ latin-1-postfix RET C-s a a

    This could be fixed in `isearch-lazy-highlight-update' by selecting
    the window where isearch was activated.

That seems reasonable, but if the idea is to call the
isearch-lazy-highlight code from query-replace as well, please verify
that this fix is correct for that case too.  I have no specific reason
to think it is wrong, I'm just asking you to double-check.

    3. While typing a sequence of a multi-character input method in the
    isearch minibuffer, the first part of the isearch string is
    highlighted in `minibuffer-prompt' face, because it is used as the
    part of the prompt.  Instead, it could be inserted into the minibuffer
    as initial-contents.

I suppose you've tested that patch; but I wonder, does this lead
to a danger of being able to edit that initial contents?

  parent reply	other threads:[~2004-12-13 19:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-10  2:06 isearch highlighting Juri Linkov
2004-12-10  3:21 ` Stefan Monnier
2004-12-10  5:22   ` Juri Linkov
2004-12-13 19:51 ` Richard Stallman [this message]
2004-12-14 10:27   ` Juri Linkov
2004-12-15 14:58     ` Richard Stallman
2004-12-17 15:29   ` Juri Linkov
2004-12-20 10:56     ` Richard Stallman
2004-12-20 20:57       ` Juri Linkov
2005-01-06  7:54         ` Juri Linkov
2005-01-09  3:23           ` Richard Stallman
2005-01-09 21:40           ` Stefan Monnier
2005-01-11 14:30             ` Richard Stallman
2005-01-12  1:52               ` Juri Linkov
  -- strict thread matches above, loose matches on Subject: below --
2004-12-10  7:00 klaus.berndl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1CdwEC-0005Rk-MR@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).