From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: query-replace highlighting
Date: Mon, 13 Dec 2004 14:51:26 -0500 [thread overview]
Message-ID: <E1CdwEA-0005RT-PU@fencepost.gnu.org> (raw)
In-Reply-To: <87ekhy6h5i.fsf@jurta.org> (message from Juri Linkov on Fri, 10 Dec 2004 04:06:33 +0200)
This seems like a good feature. However, it is inconsistent
to control it by giving query-replace-highlight a third possible value.
For the case of isearch, we did not give search-highlight a third
possible value. We made a new option, isearch-lazy-highlight.
So we should make a new option, query-replace-lazy-highlight.
Could you please do that?
With this new feature, most of the options in the group
isearch-lazy-highlight are no longer specific to isearch. It would be
better to call the custom group lazy-highlight-matches, and rename all
the options accordingly, making the old names aliases and marking them
obsolete.
The option isearch-lazy-highlight should not be renamed. But the
function isearch-lazy-highlight-new-loop should not test it. Instead,
the caller in isearch.el should test isearch-lazy-highlight before
calling isearch-lazy-highlight-new-loop. The caller in replace.el
would test query-replace-lazy-highlight instead.
The custom group lazy-highlight-matches should have multiple parent
groups, `isearch' and `matching'. That way, people will find it
in both contexts.
Would you like to do these things to finish it up right,
then install your patch?
next prev parent reply other threads:[~2004-12-13 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-10 2:06 query-replace highlighting Juri Linkov
2004-12-13 19:51 ` Richard Stallman [this message]
2004-12-14 10:34 ` Juri Linkov
2004-12-15 14:58 ` Richard Stallman
2004-12-15 12:00 ` Juri Linkov
2005-01-12 1:54 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1CdwEA-0005RT-PU@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).