From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-trunk-diffs] Changes to emacs/etc/NEWS Date: Tue, 07 Dec 2004 23:40:39 -0500 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1102481172 3820 80.91.229.6 (8 Dec 2004 04:46:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 8 Dec 2004 04:46:12 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 08 05:46:08 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CbtiJ-0006EI-00 for ; Wed, 08 Dec 2004 05:46:08 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cbts9-0001xH-Bq for ged-emacs-devel@m.gmane.org; Tue, 07 Dec 2004 23:56:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CbtqP-0001Jz-9X for emacs-devel@gnu.org; Tue, 07 Dec 2004 23:54:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CbtqO-0001JQ-9X for emacs-devel@gnu.org; Tue, 07 Dec 2004 23:54:28 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CbtqO-0001JL-2U for emacs-devel@gnu.org; Tue, 07 Dec 2004 23:54:28 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CbtgO-0003SM-QQ for emacs-devel@gnu.org; Tue, 07 Dec 2004 23:44:08 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1Cbtd1-0003xK-By; Tue, 07 Dec 2004 23:40:39 -0500 Original-To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Tue, 07 Dec 2004 00:33:55 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30842 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30842 ** An unconditional face specification in defface (one where the DISPLAY part is just t) applies to all cases and does not override subsequent entries. This feature does not seem cleanly designed to me. The first slot in the spec is supposed to be a condition, and t as a condition has a very clear meaning in Lisp. To use t for any other meaning seems very wrong. It also seems that this change wasn't fully implemented, because the code in cus-edit.el that interprets face specs doesn't know about it. I think we should replace this with a clean feature before releasing it. Here's one idea for a clean feature: t as the condition means "or else", as it used to, as people would expect. nil as the condition means "default", attributes to be shared by all the conditions. It should not be very hard to implement this in faces.el instead of the current code. However, it needs to be implemented also in cus-edit.el, which is harder, and in the Lisp manual. Also, someone needs to check all 500-odd deffaces, but that probably needs to be done anyway, and most of them will take only a few seconds to see there's no issue. Can you or someone please undertake to do this?