* vertical-motion behavior change
@ 2004-12-03 16:59 Dan Nicolaescu
2004-12-04 21:18 ` Peter Heslin
2004-12-07 4:24 ` Richard Stallman
0 siblings, 2 replies; 5+ messages in thread
From: Dan Nicolaescu @ 2004-12-03 16:59 UTC (permalink / raw)
Sometime in the past month the behavior of (vertical-motion 0) has
changed.
For sources checked out of CVS on Nov 1st, (vertical-motion 0) would
move the point to the beginning of the line.
For the current CVS sources (vertical-motion 0) would not move the
point.
term.el relies on the old behavior in a few places, and not it does
not work correctly anymore...
Is this change intentional, or is an unwanted side effect?
--dan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: vertical-motion behavior change
2004-12-03 16:59 vertical-motion behavior change Dan Nicolaescu
@ 2004-12-04 21:18 ` Peter Heslin
2004-12-07 4:24 ` Richard Stallman
1 sibling, 0 replies; 5+ messages in thread
From: Peter Heslin @ 2004-12-04 21:18 UTC (permalink / raw)
On 2004-12-03, Dan Nicolaescu <dann@godzilla.ics.uci.edu> wrote:
>
> Sometime in the past month the behavior of (vertical-motion 0) has
> changed.
> For sources checked out of CVS on Nov 1st, (vertical-motion 0) would
> move the point to the beginning of the line.
> For the current CVS sources (vertical-motion 0) would not move the
> point.
>
> term.el relies on the old behavior in a few places, and not it does
> not work correctly anymore...
This would also explain why screen-lines.el (not part of Emacs)
stopped working correctly at about that point in time.
> Is this change intentional, or is an unwanted side effect?
There are other packages that rely on the old behavior, and the
doc-string might have been interpreted to guarantee it:
Move point to start of the screen line LINES lines down.
To me, that implies that a value of zero for LINES should move point
to the start of the current line.
Peter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: vertical-motion behavior change
2004-12-03 16:59 vertical-motion behavior change Dan Nicolaescu
2004-12-04 21:18 ` Peter Heslin
@ 2004-12-07 4:24 ` Richard Stallman
2004-12-07 12:04 ` Peter Heslin
2004-12-07 16:42 ` Dan Nicolaescu
1 sibling, 2 replies; 5+ messages in thread
From: Richard Stallman @ 2004-12-07 4:24 UTC (permalink / raw)
Cc: emacs-devel
Does this change give correct results?
*** indent.c 23 Nov 2004 11:44:50 -0500 1.172
--- indent.c 06 Dec 2004 16:09:41 -0500
***************
*** 2092,2099 ****
move_it_by_lines (&it, -1, 0);
it.vpos = 0;
! if (XINT (lines) != 0)
! move_it_by_lines (&it, XINT (lines), 0);
SET_PT_BOTH (IT_CHARPOS (it), IT_BYTEPOS (it));
}
--- 2092,2098 ----
move_it_by_lines (&it, -1, 0);
it.vpos = 0;
! move_it_by_lines (&it, XINT (lines), 0);
SET_PT_BOTH (IT_CHARPOS (it), IT_BYTEPOS (it));
}
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-12-07 16:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-03 16:59 vertical-motion behavior change Dan Nicolaescu
2004-12-04 21:18 ` Peter Heslin
2004-12-07 4:24 ` Richard Stallman
2004-12-07 12:04 ` Peter Heslin
2004-12-07 16:42 ` Dan Nicolaescu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).