From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-trunk-diffs] Changes to emacs/src/sysdep.c Date: Sat, 27 Nov 2004 01:55:25 -0500 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1101538710 19945 80.91.229.6 (27 Nov 2004 06:58:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 27 Nov 2004 06:58:30 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 27 07:58:27 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CXwXL-0002DS-00 for ; Sat, 27 Nov 2004 07:58:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CXwgc-00038Z-8r for ged-emacs-devel@m.gmane.org; Sat, 27 Nov 2004 02:08:02 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CXwg1-0002uq-BT for emacs-devel@gnu.org; Sat, 27 Nov 2004 02:07:25 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CXwg0-0002ua-JX for emacs-devel@gnu.org; Sat, 27 Nov 2004 02:07:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CXwg0-0002uW-HF for emacs-devel@gnu.org; Sat, 27 Nov 2004 02:07:24 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CXwWc-00026N-RH for emacs-devel@gnu.org; Sat, 27 Nov 2004 01:57:42 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1CXwUP-0001bZ-42; Sat, 27 Nov 2004 01:55:25 -0500 Original-To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Thu, 25 Nov 2004 15:07:46 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30421 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30421 I haven't been following the thread, but it seems to have led to a change in sysdep.c that seems unfortunate. Until now, there has been no quitting inside writing a file, which means that the file can't end up truncated as a result of quitting. What was the reason for this change? What problem is it meant to solve? *************** *** 3279,3285 **** if (rtnval == -1) { if (errno == EINTR) ! continue; else return (bytes_written ? bytes_written : -1); } --- 3285,3291 ---- if (rtnval == -1) { if (errno == EINTR) ! { QUIT; continue; } else return (bytes_written ? bytes_written : -1); }